Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1344600
| From | Dave Hansen <dave.hansen@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] x86/mpx: Fix off-by-one comparison with nr_registers |
| Date | 2016-02-26 20:20 +0100 |
| Message-ID | <r6w5H-7UQ-5@gated-at.bofh.it> (permalink) |
| References | <r6vMn-7w1-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 02/26/2016 10:55 AM, Colin King wrote: > In the unlikely event that regno == nr_registers then we get an array > overrun on regoff because the invalid register check is currently > off-by-one. Fix this with a check that regno is >= nr_registers instead. > > Detected with static analysis using CoverityScan. Oh, the irony of an overrun in the MPX code! Thanks for catching this. Acked-by: Dave Hansen <dave.hansen@intel.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] x86/mpx: Fix off-by-one comparison with nr_registers Colin King <colin.king@canonical.com> - 2016-02-26 20:00 +0100 Re: [PATCH] x86/mpx: Fix off-by-one comparison with nr_registers Dave Hansen <dave.hansen@linux.intel.com> - 2016-02-26 20:20 +0100 [tip:x86/urgent] x86/mpx: Fix off-by-one comparison with nr_registers tip-bot for Colin Ian King <tipbot@zytor.com> - 2016-02-26 22:20 +0100
csiph-web