Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1344425

Re: [lustre-devel] [PATCH v2 0/6] staging: lustre: update modinfo data

Show all headers | View raw

On Fri, Feb 26, 2016 at 03:46:02PM +0000, Simmons, James A. wrote:
> >On Fri, Feb 26, 2016 at 06:11:07AM +0000, Drokin, Oleg wrote:
> >> 
> >> On Feb 26, 2016, at 1:03 AM, Greg Kroah-Hartman wrote:
> >> 
> >> > On Thu, Feb 25, 2016 at 08:07:06PM -0500, James Simmons wrote:
> >> >> The module information for Lustre is stale or in some cases
> >> >> completely missing. This collection of patches brings the
> >> >> modinfo up to date as well as filling in any missing information.
> >> >> This patch set has been redone to rebase it on Oleg's latest
> >> >> patch set to avoid collisons in merging.
> >> >> 
> >> >> Andreas Dilger (4):
> >> >>  staging: lustre: add missing MODULE_AUTHOR for LNet selftest module
> >> >>  staging: lustre: update the MODULE_DESCRIPTION for all lustre modules
> >> >>  staging: lustre: make module_init/exit naming consistent
> >> >>  staging: lustre: update comment for lnet_lib_init/exit
> >> >> 
> >> >> James Simmons (2):
> >> >>  staging: lustre: move module info to end of libcfs module.c file
> >> >>  staging: lustre: update the MODULE_VERSION for all lustre modules
> >> > 
> >> > What changed to need a v2 of this series?
> >> > 
> >> > Please ALWAYS say what the difference is, don't expect us to "just
> >> > know".
> >> > 
> >> > Please send a v3 of this, describing the changes, in the correct format,
> >> > in each patch.  You know better than this…
> >> 
> >> I think it says above that the rebase was done on top of my patchset
> >> to resolve the conflict that arose?
> >
> >Where?  Ugh, yeah, kind of, but where is the big v2: marking or some
> >such thing like is required?  It's very easy to miss this (as I did.)
> >Please make it easy for maintainers, not hard on them...
> 
> Sorry, in the future I will add a ChangeLog section for newer versions of patches.
> The good news is the patches from Oleg's that conflicted landed already which
> means the this patch set is ready to land.

Can you please resend it with the proper format?  It's out of my queue
now...

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] staging: lustre: update modinfo data James Simmons <jsimmons@infradead.org> - 2016-02-26 02:20 +0100
  [PATCH v2 2/6] staging: lustre: add missing MODULE_AUTHOR for LNet selftest module James Simmons <jsimmons@infradead.org> - 2016-02-26 02:20 +0100
  [PATCH v2 6/6] staging: lustre: update comment for lnet_lib_init/exit James Simmons <jsimmons@infradead.org> - 2016-02-26 02:20 +0100
  [PATCH v2 5/6] staging: lustre: make module_init/exit naming consistent James Simmons <jsimmons@infradead.org> - 2016-02-26 02:20 +0100
  [PATCH v2 4/6] staging: lustre: update the MODULE_DESCRIPTION for all lustre modules James Simmons <jsimmons@infradead.org> - 2016-02-26 02:20 +0100
  [PATCH v2 1/6] staging: lustre: move module info to end of libcfs module.c file James Simmons <jsimmons@infradead.org> - 2016-02-26 02:20 +0100
  Re: [PATCH v2 0/6] staging: lustre: update modinfo data Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-26 07:10 +0100
    Re: [lustre-devel] [PATCH v2 0/6] staging: lustre: update modinfo  data "Drokin, Oleg" <oleg.drokin@intel.com> - 2016-02-26 07:20 +0100
      Re: [lustre-devel] [PATCH v2 0/6] staging: lustre: update modinfo data Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-26 07:30 +0100
        RE: [lustre-devel] [PATCH v2 0/6] staging: lustre: update modinfo  data "Simmons, James A." <simmonsja@ornl.gov> - 2016-02-26 16:50 +0100
          Re: [lustre-devel] [PATCH v2 0/6] staging: lustre: update modinfo data 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org> - 2016-02-26 17:40 +0100

csiph-web