Re: [PATCH v5 10/20] kthread: Better support freezable kthread workers

From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 10/20] kthread: Better support freezable kthread workers
Date	2016-02-26 16:50 +0100
Message-ID	<r6sOt-5pp-13@gated-at.bofh.it> (permalink)
References	<r507T-7eO-3@gated-at.bofh.it> <r507U-7eO-29@gated-at.bofh.it> <r63Q7-4en-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu 2016-02-25 14:01:15, Peter Zijlstra wrote:
> On Mon, Feb 22, 2016 at 03:57:00PM +0100, Petr Mladek wrote:
> > +enum {
> > +	KTW_FREEZABLE		= 1 << 2,	/* freeze during suspend */
> > +};
> 
> Weird value; what was wrong with 1 << 0 ?

Heh, the flag was inspired by

	WQ_FREEZABLE		= 1 << 2, /* freeze during suspend */

from include/linux/workqueue.h. But it does not really matter.
I could change it to 1 << 0 if it makes people less curious.

Thanks a lot for review,
Petr

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 10/20] kthread: Better support freezable kthread  workers Peter Zijlstra <peterz@infradead.org> - 2016-02-25 14:10 +0100
  Re: [PATCH v5 10/20] kthread: Better support freezable kthread  workers Petr Mladek <pmladek@suse.com> - 2016-02-26 16:50 +0100

csiph-web