Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1344272

Re: [PATCH 2/2] crypto: remove padding logic from rsa.c

From David Howells <dhowells@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] crypto: remove padding logic from rsa.c
Date 2016-02-26 15:10 +0100
Message-ID <r6rfI-4re-7@gated-at.bofh.it> (permalink)
References <r5Lgw-7GJ-39@gated-at.bofh.it> <r5Lgu-7GJ-5@gated-at.bofh.it> <r5Lgw-7GJ-39@gated-at.bofh.it>
Organization Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw


Tadeusz Struk <tadeusz.struk@intel.com> wrote:

> +		if (memcmp(sig->digest, output, sig->digest_size) ||

I've added " != 0" after the memcmp().

> +		    req->dst_len != sig->digest_size)
> +			ret = -EBADMSG;

Btw, this has to be -EKEYREJECTED; -EBADMSG would indicate that the container
is unparseable.  I wonder if we should propose a -ESIGREJECTED error...

David

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] crypto: remove padding logic from rsa.c Tadeusz Struk <tadeusz.struk@intel.com> - 2016-02-24 18:20 +0100
  Re: [PATCH 2/2] crypto: remove padding logic from rsa.c David Howells <dhowells@redhat.com> - 2016-02-26 15:10 +0100
  Re: [PATCH 2/2] crypto: remove padding logic from rsa.c David Howells <dhowells@redhat.com> - 2016-02-26 16:10 +0100
  Re: [PATCH 2/2] crypto: remove padding logic from rsa.c Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-27 19:50 +0100
    Re: [PATCH 2/2] crypto: remove padding logic from rsa.c Tadeusz Struk <tadeusz.struk@intel.com> - 2016-02-28 04:30 +0100

csiph-web