Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1344233

Re: [PATCH 1/2] spi: sun4i: add DMA support

Show all headers | View raw

Hello,

On 26 February 2016 at 13:25, Mark Brown <broonie@kernel.org> wrote:
> On Fri, Feb 26, 2016 at 07:56:56AM +0200, Priit Laes wrote:
>> From: Emilio López <emilio@elopez.com.ar>
>>
>> This patch adds support for 64 byte or bigger transfers on the
>> sun4i SPI controller. Said transfers will be performed via DMA.
>>
>> Signed-off-by: Emilio López <emilio@elopez.com.ar>
>> Tested-by: Michal Suchanek <hramrach@gmail.com>
>> Tested-by: Priit Laes <plaes@plaes.org>
>> ---
>
> You *must* sign off any patches you are sending, please see
> SubmittingPatches.

I have sent these patches in the past. Besides this non-technical
objection there were multiple technical objections.

IIRC one was that the driver does not handle the case when the DMA
channels are not available. As I understand it the channels are
exclusively reserved for a particular peripherial on sunxi platform so
this ShoulNotHappen(tm). So it's probably fine for the driver to fail
probe  when you have broken DT or no DMA engine support for sunxi
platform.

The driver could also work fully without DMA and there is a patch for
that also but since nobody will be testing that codepath it's probably
better to not include it.

I have not addressed the other objections so far.

Thanks

Michal

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND 0/2] spi: sun4i: add DMA support Priit Laes <plaes@plaes.org> - 2016-02-26 07:00 +0100
  [PATCH 1/2] spi: sun4i: add DMA support Priit Laes <plaes@plaes.org> - 2016-02-26 07:00 +0100
    Re: [PATCH 1/2] spi: sun4i: add DMA support Mark Brown <broonie@kernel.org> - 2016-02-26 13:30 +0100
      Re: [PATCH 1/2] spi: sun4i: add DMA support Michal Suchanek <hramrach@gmail.com> - 2016-02-26 14:00 +0100
  [PATCH 2/2] ARM: sunxi: spi: add notice about SPI FIFO limit. Priit Laes <plaes@plaes.org> - 2016-02-26 07:00 +0100
  Re: [PATCH RESEND 0/2] spi: sun4i: add DMA support Mark Brown <broonie@kernel.org> - 2016-02-26 13:20 +0100

csiph-web