Re: [PATCH] KVM: x86: fix root cause for missed hardware breakpoints

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] KVM: x86: fix root cause for missed hardware breakpoints
Date	2016-02-26 13:50 +0100
Message-ID	<r6q0i-3i6-11@gated-at.bofh.it> (permalink)
References	<r6p4e-2AD-1@gated-at.bofh.it> <r6pnA-2Zo-5@gated-at.bofh.it> <r6pxg-331-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 26/02/2016 13:14, Nadav Amit wrote:
> Seems correct. The code may be easier to follow if the following line:
> 
> vcpu->arch.switch_db_regs &= ~KVM_DEBUGREG_WONT_EXIT
> 
> would have been moved out of svm_sync_dirty_debug_regs and
> vmx_sync_dirty_debug_regs into the flow of vcpu_enter_guest (above).

It is there because removing the bit is tied to actually enabling debug
register exits.  On one hand it's bad to have duplicated code, on the
other hand there's a reason for it...  I'm a bit undecided on whether to
move that duplicated line to x86.c.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] KVM: x86: fix root cause for missed hardware breakpoints Paolo Bonzini <pbonzini@redhat.com> - 2016-02-26 12:50 +0100
  Re: [PATCH] KVM: x86: fix root cause for missed hardware breakpoints Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-02-26 13:10 +0100
    Re: [PATCH] KVM: x86: fix root cause for missed hardware breakpoints Nadav Amit <nadav.amit@gmail.com> - 2016-02-26 13:20 +0100
      Re: [PATCH] KVM: x86: fix root cause for missed hardware breakpoints Paolo Bonzini <pbonzini@redhat.com> - 2016-02-26 13:50 +0100

csiph-web