Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1344205

[PATCH 5/5] perf report: Show message for percent limit on gtk

Path csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Namhyung Kim <namhyung@kernel.org>
Newsgroups linux.kernel
Subject [PATCH 5/5] perf report: Show message for percent limit on gtk
Date Fri, 26 Feb 2016 13:20:02 +0100
Message-ID <r6pxf-331-1@gated-at.bofh.it> (permalink)
References <r6pxg-331-3@gated-at.bofh.it>
X-Original-To Arnaldo Carvalho de Melo <acme@kernel.org>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=k5gp3viSQfJeENKTmAMM5dl7v1O8XlWiXTPsVw/jX4Y=; b=jMH64siJvUvryhTshcu7CXZrB3cHINty75gdG5qZqLFmbvXEd752R/vz0c1179aZUr DmyIW1MqK2+tNDM8oJNDpyw44Aa0Vs0Xt5UGQ0uWHENOnuLsaFASeB6V1p19iCZlvjrh AI/jQ34UZctujEULtXNof+xYWZUepiDpK87fJkRysorC4NbeaV1OEkMhDYyY0pWOY9PX Ou75+zeqFL6ur3AeeMy+TP3mUGpudtYmhcTyaA5sw6xfa/BEi90Id50Hxw1yCChUs80b HL4poxaase/wuBY04aGsIkJak6rN/6YkAG64jZ2tSo0NtEuZGYjgnjmTpKvGwFqlgBEK El0w==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=k5gp3viSQfJeENKTmAMM5dl7v1O8XlWiXTPsVw/jX4Y=; b=W7sMh2SUdid1DE6t+q2zbAA9sGJ5sg41sogVHKMwHPEt2x0covN+KQ1SXcnbXpNz28 pjjpUJv9U06ywBnGAvXeQ36AAEefJxf9R0PecfrDALwbE8j3fMu1C/Sk4850WJSD7K67 XSzpCOGdBpxlzUgTkAhcd3hkrh7jrLtH1hmeqCglC7Ct79WJ/F2Ke1UpA5DX72lids+j eSZ4JcKdtbJq2MK5vaoYzVj4dpmp5nkDsor4IRV+zCSlwRvMOuKVshMvxQg2+FfLdAcp 3RxsRLRz+iube+WXeezha2hTatkmVQbfKKQRrCGVnRttkQO54Zhl9nTON2fPiYdXMwSr GOaQ==
X-Gm-Message-State AD7BkJJ6F1hsCX4tl+V9WiNNtBDIlq0P3cFgAad4A16Z645bQx96fGK9HD3C6bqOdSsCaw==
X-Received by 10.66.102.37 with SMTP id fl5mr1607044pab.32.1456488892846; Fri, 26 Feb 2016 04:14:52 -0800 (PST)
X-Mailer git-send-email 2.7.1
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 32
Organization linux.* mail to news gateway
X-Original-Cc Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>, Stephane Eranian <eranian@google.com>, Wang Nan <wangnan0@huawei.com>
X-Original-Date Fri, 26 Feb 2016 21:13:20 +0900
X-Original-Message-ID <1456488800-28124-5-git-send-email-namhyung@kernel.org>
X-Original-References <1456488800-28124-1-git-send-email-namhyung@kernel.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1344205

Show key headers only | View raw


Like the stdio, it should show messages about omitted hierarchy
entries.  Please refer the previous commit for more details.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/ui/gtk/hists.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tools/perf/ui/gtk/hists.c b/tools/perf/ui/gtk/hists.c
index 7f343339eae7..a5758fdfbe1f 100644
--- a/tools/perf/ui/gtk/hists.c
+++ b/tools/perf/ui/gtk/hists.c
@@ -449,6 +449,17 @@ static void perf_gtk__add_hierarchy_entries(struct hists *hists,
 			perf_gtk__add_hierarchy_entries(hists, &he->hroot_out,
 							store, &iter, hpp,
 							min_pcnt);
+
+			if (!hist_entry__has_hierarchy_children(he, min_pcnt)) {
+				char buf[32];
+				GtkTreeIter child;
+
+				snprintf(buf, sizeof(buf), "no entry >= %.2f%%",
+					 min_pcnt);
+
+				gtk_tree_store_append(store, &child, &iter);
+				gtk_tree_store_set(store, &child, col_idx, buf, -1);
+			}
 		}
 
 		if (symbol_conf.use_callchain && he->leaf) {
-- 
2.7.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH 5/5] perf report: Show message for percent limit on gtk Namhyung Kim <namhyung@kernel.org> - 2016-02-26 13:20 +0100
  [tip:perf/core] perf report: Show message for percent limit on gtk tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-27 10:50 +0100

csiph-web