Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1344164

Re: [PATCH] rtc: pcf85063: remove useless century handling

From Juergen Borleis <jbe@pengutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH] rtc: pcf85063: remove useless century handling
Date 2016-02-26 12:10 +0100
Message-ID <r6orz-2jv-85@gated-at.bofh.it> (permalink)
References <r5ufD-44a-7@gated-at.bofh.it>
Organization Pengutronix e.K.

Show all headers | View raw


Hi Alexandre,

On Wednesday 24 February 2016 00:05:28 Alexandre Belloni wrote:
> pcf85063_get_datetime() tries to handle a century bit but that bit is not
> documented and the final value is never used anywhere else in the kernel.
> [...]
> However, I found two interesting things in that driver. I'll send a
> patch shortly, removing the useless century handling.
> Also, I'm quite unsure about the year range handling. I have a patch but
> I'm not sure about the RTC behaviour when the year goes from 99 to 00.
> Can you check that works properly?

Just returned from the embedded world exhibition... Will test it.

Regards,
Juergen

-- 
Pengutronix e.K.                              | Juergen Borleis             |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] rtc: pcf85063: remove useless century handling Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-02-24 00:10 +0100
  Re: [PATCH] rtc: pcf85063: remove useless century handling Juergen Borleis <jbe@pengutronix.de> - 2016-02-26 12:10 +0100
  Re: [PATCH] rtc: pcf85063: remove useless century handling Juergen Borleis <jbe@pengutronix.de> - 2016-03-01 09:30 +0100

csiph-web