Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1344068
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] mfd: Provide MACRO to declare commonly defined MFD cell attributes |
| Date | 2016-02-26 11:50 +0100 |
| Message-ID | <r6o8a-1Sy-19@gated-at.bofh.it> (permalink) |
| References | <r0hsK-5dn-13@gated-at.bofh.it> <r0F22-3Zd-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Feb 10, 2016 at 5:38 PM, Lee Jones <lee.jones@linaro.org> wrote:
> mfd: Provide MACRO to declare commonly defined MFD cell attributes
>
Commit message?
> +#define MFD_ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
What's wrong with ARRAY_SIZE() ?
> +
> +#define MFD_CELL_ALL(_name, _res, _pdata, _id, _compat, _match) \
It misses pset. Which makes below set of macros is not sufficient.
> + { \
> + .name = (_name), \
> + .resources = (_res), \
> + .num_resources = MFD_ARRAY_SIZE((_res)), \
> + .platform_data = (_pdata), \
> + .pdata_size = MFD_ARRAY_SIZE((_pdata)), \
> + .of_compatible = (_compat), \
> + .acpi_match = (_match), \
> + .id = _id, \
> + }
> +
> +#define OF_MFD_CELL(_name, _res, _pdata, _id, _compat) \
> + MFD_CELL_ALL(_name, _res, _pdata, _id, _compat, NULL) \
> +
> +#define ACPI_MFD_CELL(_name, _res, _pdata, _id, _match) \
> + MFD_CELL_ALL(_name, _res, _pdata, _id, NULL, _match) \
> +
> +#define MFD_CELL_BASIC(_name, _res, _pdata, _id) \
> + MFD_CELL_ALL(_name, _res, _pdata, _id, NULL, NULL) \
> +
> +#define MFD_CELL_NAME(_name) \
> + MFD_CELL_ALL(_name, NULL, NULL, 0, NULL, NULL) \
--
With Best Regards,
Andy Shevchenko
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v2] mfd: Provide MACRO to declare commonly defined MFD cell attributes Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-26 11:50 +0100
csiph-web