Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1343720

Re: [REGRESSION] 8a3e33cf92c7 "ata: ahci: find eSATA ports and flag them as removable" changes userspace behavior

Show all headers | View raw

On 02/25/2016 11:09 AM, Manuel Lauss wrote:
> On Thu, Feb 25, 2016 at 6:12 PM, Laura Abbott <labbott@redhat.com> wrote:
>> Hi,
>>
>> We received a bugzilla report
>> https://bugzilla.redhat.com/show_bug.cgi?id=1310682
>> of partitions being automounted unexpectedly. Testing showed that
>> 8a3e33cf92c7 ("ata: ahci: find eSATA ports and flag them as removable") was
>> responsible.
>> This seems to be classified as 'breaking' userspace given that this behavior
>> results
>> in partitions that were previously unmounted now being being mounted
>> unwanted
>> automatically which is unwanted behavior for the user. Can we revert this
>> patch or
>> give a fix to change this behavior?
>
> Can you test this?  I think the old HPCP bit should just be ignored,
> although windows does use it, i.e. when I enable hotplug capability
> in the bios on my desktop it shows the  "eject device" icon for a device
> attached to the port on the motherboard, we probably can ignore it
> on linux to not break all automounting distros.  On my laptop, where
> I care about this, it still works as intended.
>
> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> index 4029679..e029e3c 100644
> --- a/drivers/ata/libahci.c
> +++ b/drivers/ata/libahci.c
> @@ -1164,8 +1164,7 @@ static void ahci_port_init(struct device *dev,
> struct ata_port *ap,
>
>          /* mark esata ports */
>          tmp = readl(port_mmio + PORT_CMD);
> -       if ((tmp & PORT_CMD_HPCP) ||
> -           ((tmp & PORT_CMD_ESP) && (hpriv->cap & HOST_CAP_SXS)))
> +       if ((tmp & PORT_CMD_ESP) && (hpriv->cap & HOST_CAP_SXS))
>                  ap->pflags |= ATA_PFLAG_EXTERNAL;
>   }
>

At least one user reported that this fixed the issue and he said
you could add

Tested-by: Bob Schultz <bob@engineer.com>

Thanks,
Laura

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[REGRESSION] 8a3e33cf92c7 "ata: ahci: find eSATA ports and flag them  as removable" changes userspace behavior Laura Abbott <labbott@redhat.com> - 2016-02-25 18:20 +0100
  Re: [REGRESSION] 8a3e33cf92c7 "ata: ahci: find eSATA ports and flag  them as removable" changes userspace behavior Manuel Lauss <manuel.lauss@gmail.com> - 2016-02-25 19:50 +0100
  Re: [REGRESSION] 8a3e33cf92c7 "ata: ahci: find eSATA ports and flag  them as removable" changes userspace behavior Manuel Lauss <manuel.lauss@gmail.com> - 2016-02-25 20:00 +0100
    Re: [REGRESSION] 8a3e33cf92c7 "ata: ahci: find eSATA ports and flag  them as removable" changes userspace behavior Laura Abbott <labbott@redhat.com> - 2016-02-25 20:40 +0100
      Re: [REGRESSION] 8a3e33cf92c7 "ata: ahci: find eSATA ports and flag  them as removable" changes userspace behavior Tejun Heo <tj@kernel.org> - 2016-02-25 22:30 +0100
  Re: [REGRESSION] 8a3e33cf92c7 "ata: ahci: find eSATA ports and flag  them as removable" changes userspace behavior Manuel Lauss <manuel.lauss@gmail.com> - 2016-02-25 20:20 +0100
    Re: [REGRESSION] 8a3e33cf92c7 "ata: ahci: find eSATA ports and flag  them as removable" changes userspace behavior Laura Abbott <labbott@redhat.com> - 2016-02-26 02:50 +0100
      Re: [REGRESSION] 8a3e33cf92c7 "ata: ahci: find eSATA ports and flag  them as removable" changes userspace behavior Tejun Heo <tj@kernel.org> - 2016-02-27 14:10 +0100

csiph-web