Re: [PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails

From	Kuba Kicinski <kubakici@wp.pl>
Newsgroups	linux.kernel
Subject	Re: [PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails
Date	2016-02-26 00:50 +0100
Message-ID	<r6dPs-2Ti-13@gated-at.bofh.it> (permalink)
References	<r6dw5-2Lc-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 25 February 2016 18:24:27 GMT-05:00, Colin King <colin.king@canonical.com> wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>If the allocation of ivp fails the error handling attempts to
>free an uninitialized dma_buf; this data structure just contains
>garbage on the stack, so the freeing will cause issues when the
>urb, buf and dma fields are free'd. Fix this by not free'ing the
>dma_buf if the ivp allocation fails.
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>

LGTM, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails Colin King <colin.king@canonical.com> - 2016-02-26 00:30 +0100
  Re: [PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails Julian Calaby <julian.calaby@gmail.com> - 2016-02-26 00:40 +0100
  Re: [PATCH][V3] mt7601u: do not free dma_buf when ivp allocation fails Kuba Kicinski <kubakici@wp.pl> - 2016-02-26 00:50 +0100

csiph-web