Re: [PATCH v17 4/9] x86/objtool: Add STACK_FRAME_NON_STANDARD macro

From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v17 4/9] x86/objtool: Add STACK_FRAME_NON_STANDARD macro
Date	2016-02-25 21:30 +0100
Message-ID	<r6aHV-HU-17@gated-at.bofh.it> (permalink)
References	<r5KDL-7ce-9@gated-at.bofh.it> <r5KDO-7ce-61@gated-at.bofh.it> <r5Z06-zs-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 25, 2016 at 08:51:49AM +0100, Ingo Molnar wrote:
> > diff --git a/include/linux/objtool.h b/include/linux/objtool.h
> > new file mode 100644
> > index 0000000..cce9d67
> > --- /dev/null
> > +++ b/include/linux/objtool.h
> 
> So I think this should really be in asm/frame.h, not in an objtool specific 
> header.

I agree that it shouldn't be in an objtool-specific header, but
asm/frame.h wouldn't work unless we added that file to all the arches.
And the macro's functionality is arch-independent anyway.  So I'm
renaming the file to include/linux/frame.h.

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v17 4/9] x86/objtool: Add STACK_FRAME_NON_STANDARD macro Josh Poimboeuf <jpoimboe@redhat.com> - 2016-02-24 17:40 +0100
  Re: [PATCH v17 4/9] x86/objtool: Add STACK_FRAME_NON_STANDARD macro Ingo Molnar <mingo@kernel.org> - 2016-02-25 09:00 +0100
    Re: [PATCH v17 4/9] x86/objtool: Add STACK_FRAME_NON_STANDARD macro Josh Poimboeuf <jpoimboe@redhat.com> - 2016-02-25 21:30 +0100

csiph-web