Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1345118

checkpatch.pl false positives on asm single line statements

From Jeff Merkey <linux.mdb@gmail.com>
Newsgroups linux.kernel
Subject checkpatch.pl false positives on asm single line statements
Date 2016-02-28 01:00 +0100
Message-ID <r6WWe-23d-3@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Joe,

Ran across a false positive case on asm volatile single line
statements.  If you
use asm volatile it assumes its a complex statement fires off an error:

# ./scripts/checkpatch.pl --strict test.patch

ERROR: Macros with complex values should be enclosed in parentheses
#9: FILE: arch/x86/include/asm/bug.h:42:
+#define BREAKL() asm volatile("int3")

ERROR: Missing Signed-off-by: line(s)

total: 2 errors, 0 warnings, 0 checks, 8 lines checked

temp.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Jeff

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

checkpatch.pl false positives on asm single line statements Jeff Merkey <linux.mdb@gmail.com> - 2016-02-28 01:00 +0100

csiph-web