Re: [PATCH 1/2] lib/mpi: avoid assembler warning

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] lib/mpi: avoid assembler warning
Date	Sat, 27 Feb 2016 20:40:01 +0100
Message-ID	<r6SSB-7LP-5@gated-at.bofh.it> (permalink)
References	<r6q0i-3i6-7@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	linux-arm-kernel@lists.infradead.org, Dmitry Kasatkin <dmitry.kasatkin@intel.com>, linux-crypto@vger.kernel.org, David Howells <dhowells@redhat.com>, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 27 Feb 2016 20:35:32 +0100
X-Original-Message-ID	<20160227193532.GF9123@gondor.apana.org.au>
X-Original-References	<1456490794-1034544-1-git-send-email-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1345072

Show key headers only | View raw

On Fri, Feb 26, 2016 at 01:46:26PM +0100, Arnd Bergmann wrote:
> A wrapper around the umull assembly instruction might reuse
> the input register as an output, which is undefined on
> some ARM machines, as pointed out by this assembler warning:
> 
>   CC      lib/mpi/generic_mpih-mul1.o
> /tmp/ccxJuxIy.s: Assembler messages:
> /tmp/ccxJuxIy.s:53: rdhi, rdlo and rm must all be different
>   CC      lib/mpi/generic_mpih-mul2.o
> /tmp/ccI0scAD.s: Assembler messages:
> /tmp/ccI0scAD.s:53: rdhi, rdlo and rm must all be different
>   CC      lib/mpi/generic_mpih-mul3.o
> /tmp/ccMvVQcp.s: Assembler messages:
> /tmp/ccMvVQcp.s:53: rdhi, rdlo and rm must all be different
> 
> This changes the constraints to force different registers to
> be used as output.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Both applied.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] lib/mpi: avoid assembler warning Arnd Bergmann <arnd@arndb.de> - 2016-02-26 13:50 +0100
  [PATCH 2/2] lib/mpi: use "static inline" instead of "extern inline" Arnd Bergmann <arnd@arndb.de> - 2016-02-26 13:50 +0100
  Re: [PATCH 1/2] lib/mpi: avoid assembler warning Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-27 20:40 +0100

csiph-web