Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1345062

Re: [PATCH 3/3] 3c59x: Use setup_timer()

Show all headers | View raw

On Thu, 25 Feb 2016, David Miller wrote:

> From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> Date: Wed, 24 Feb 2016 19:28:19 +0530
>
>> Convert a call to init_timer and accompanying intializations of
>> the timer's data and function fields to a call to setup_timer.
>>
>> The Coccinelle semantic patch that fixes this problem is
>> as follows:
>>
>> // <smpl>
>> @@
>> expression t,f,d;
>> @@
>>
>> -init_timer(&t);
>> +setup_timer(&t,f,d);
>>  ...
>> -t.data = d;
>> -t.function = f;
>> // </smpl>
>>
>> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
>
> Applied.

Hi David, Amitoj,

The patch here seemed to remove the call to add_timer(&vp->timer) which
applies the expires time. Would that be an issue?

-Stafford

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] 3c59x: Use setup_timer() Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-02-24 15:00 +0100
  Re: [PATCH 3/3] 3c59x: Use setup_timer() David Miller <davem@davemloft.net> - 2016-02-25 23:00 +0100
    Re: [PATCH 3/3] 3c59x: Use setup_timer() Stafford Horne <shorne@gmail.com> - 2016-02-27 19:50 +0100
      Re: [PATCH 3/3] 3c59x: Use setup_timer() Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-02-28 08:10 +0100
        Re: [PATCH 3/3] 3c59x: Use setup_timer() Stafford Horne <shorne@gmail.com> - 2016-02-28 09:00 +0100
          Re: [PATCH 3/3] 3c59x: Use setup_timer() Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-02-28 09:20 +0100
        [PATCH] 3c59x: Ensure to apply the expires time Stafford Horne <shorne@gmail.com> - 2016-02-28 09:00 +0100
          Re: [PATCH] 3c59x: Ensure to apply the expires time David Miller <davem@davemloft.net> - 2016-02-29 05:50 +0100

csiph-web