Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1345058

RE: [PATCH net 1/3] r8169:fix nic sometimes doesn't work after changing the mac address.

From Hau <hau@realtek.com>
Newsgroups linux.kernel
Subject RE: [PATCH net 1/3] r8169:fix nic sometimes doesn't work after changing the mac address.
Date 2016-02-27 19:30 +0100
Message-ID <r6RMR-73z-13@gated-at.bofh.it> (permalink)
References <r6mg3-tV-9@gated-at.bofh.it> <r6mg3-tV-17@gated-at.bofh.it> <r6A9j-2hX-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


 > Instead of taking the device out of suspended mode to perform the required
> action, the driver is moving to a model where 1) said action may be
> scheduled to a later time - or result from past time work - and 2) rpm handler
> must handle a lot of pm unrelated work.
> 
> rtl8169_ethtool_ops.{get_wol, get_regs, get_settings} aren't even fixed yet
> (what about the .set_xyz handlers ?).
> 
> I can't help thinking that the driver should return to a state where it stupidly
> does what it is asked to. No software caching, plain device access, resume
> when needed, suspend as "suspend" instead of suspend as "anticipate
> whatever may happen to avoid waking up".
>

This rpm related patches just the workaround for the issues reported by end users.  As you say, the Linux kernel should handle these events when driver is in runtime suspend state.
 
------Please consider the environment before printing this e-mail.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH net 1/3] r8169:fix nic sometimes doesn't work after changing the mac address. Chunhao Lin <hau@realtek.com> - 2016-02-26 09:50 +0100
  Re: [PATCH net 1/3] r8169:fix nic sometimes doesn't work after  changing the mac address. Francois Romieu <romieu@fr.zoreil.com> - 2016-02-27 00:40 +0100
    RE: [PATCH net 1/3] r8169:fix nic sometimes doesn't work after changing the mac address. Hau <hau@realtek.com> - 2016-02-27 19:30 +0100

csiph-web