Re: [PATCH v7] x86/setup: get ramdisk parameters only once

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7] x86/setup: get ramdisk parameters only once
Date	2016-02-27 13:00 +0100
Message-ID	<r6LHs-2pp-9@gated-at.bofh.it> (permalink)
References	<r6lai-8f1-9@gated-at.bofh.it> <r6m6l-q0-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Borislav Petkov <bp@suse.de> wrote:

> >  void __init setup_arch(char **cmdline_p)
> >  {
> > +	struct ramdisk ramdisk = {
> > +		.start_addr = get_ramdisk_image(),
> > +		.size  = PAGE_ALIGN(get_ramdisk_size()),
> > +		.reserve_ramdisk = true
> > +	};
> 
> More readable:
> 
>         struct ramdisk ramdisk = {
>                 .start_addr	 = get_ramdisk_image(),
>                 .size		 = PAGE_ALIGN(get_ramdisk_size()),
>                 .reserve_ramdisk = true,
>         };

So I find it highly annoying that this review feedback was done by Boris, but not 
implemented in v8 :-(

I'd much have preferred fewer iterations and more careful implementation, which 
would have resulted in much less time wasted on the reviewer side...

Anyway, to stop this trainwreck I've fixed this (and a few other small details) 
and applied the patch, but I'd also like to point out that from now on I'll stop 
accepting trivial patches from serial trivial patches contributors that are not 
part of some larger, more substantial work...

Thanks,

	Ingo

Thread

[PATCH v7] x86/setup: get ramdisk parameters only once Alexander Kuleshov <kuleshovmail@gmail.com> - 2016-02-26 08:40 +0100
  Re: [PATCH v7] x86/setup: get ramdisk parameters only once Borislav Petkov <bp@suse.de> - 2016-02-26 09:40 +0100
    Re: [PATCH v7] x86/setup: get ramdisk parameters only once Ingo Molnar <mingo@kernel.org> - 2016-02-27 13:00 +0100
      Re: [PATCH v7] x86/setup: get ramdisk parameters only once Borislav Petkov <bp@suse.de> - 2016-02-27 13:50 +0100

csiph-web