[patch] [media] saa7134: Fix analog TV demod detection.

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] [media] saa7134: Fix analog TV demod detection.
Date	2016-02-27 11:50 +0100
Message-ID	<r6KBI-1Bx-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

There is a missing curly brace so we only look at the first item in the
list and then exit.

Fixes: ac90aa02d5b9 ('[media] saa7134: add media controller support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/media/pci/saa7134/saa7134-core.c b/drivers/media/pci/saa7134/saa7134-core.c
index 42bc417..8f3ba40 100644
--- a/drivers/media/pci/saa7134/saa7134-core.c
+++ b/drivers/media/pci/saa7134/saa7134-core.c
@@ -838,9 +838,10 @@ static void saa7134_create_entities(struct saa7134_dev *dev)
 
 	/* Check if it is using an external analog TV demod */
 	media_device_for_each_entity(entity, dev->media_dev) {
-		if (entity->function == MEDIA_ENT_F_ATV_DECODER)
+		if (entity->function == MEDIA_ENT_F_ATV_DECODER) {
 			decoder = entity;
 			break;
+		}
 	}
 
 	/*

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[patch] [media] saa7134: Fix analog TV demod detection. Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-27 11:50 +0100

csiph-web