Re: [PATCH] Rename "trigger" reset reason "hw watchdog"

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Rename "trigger" reset reason "hw watchdog"
Date	2016-02-27 02:50 +0100
Message-ID	<r6Cb9-3Ot-9@gated-at.bofh.it> (permalink)
References	<r6t7T-5QF-71@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/26/2016 08:05 AM, Martyn Welch wrote:
> The Zodiac watchdog is implemented on a microcontoller. The reset reason
> currently labelled "trigger" is not to detect when the watchdog has
> triggered (as had been initially understood and suggested by the naming),
> but to inform the reader that the watchdog, which in fact has it's own
> hardware watchdog, has been reset because the hardware watchdog has
> triggered. Renaming to "hw watchdog".
>
> Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/ziirave_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
> index 0c7cb73..cbe373de 100644
> --- a/drivers/watchdog/ziirave_wdt.c
> +++ b/drivers/watchdog/ziirave_wdt.c
> @@ -36,7 +36,7 @@
>   #define ZIIRAVE_STATE_OFF	0x1
>   #define ZIIRAVE_STATE_ON	0x2
>
> -static char *ziirave_reasons[] = {"power cycle", "triggered", NULL, NULL,
> +static char *ziirave_reasons[] = {"power cycle", "hw watchdog", NULL, NULL,
>   				  "host request", NULL, "illegal configuration",
>   				  "illegal instruction", "illegal trap",
>   				  "unknown"};
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Rename "trigger" reset reason "hw watchdog" Martyn Welch <martyn.welch@collabora.co.uk> - 2016-02-26 17:10 +0100
  Re: [PATCH] Rename "trigger" reset reason "hw watchdog" Guenter Roeck <linux@roeck-us.net> - 2016-02-27 02:50 +0100

csiph-web