Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1343412

Re: [PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew()

Show all headers | View raw

On 02/26/2016 04:16 AM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 25, 2016 at 08:02:22PM +0100, Jiri Olsa escreveu:
>> On Fri, Feb 26, 2016 at 12:13:10AM +0900, Taeung Song wrote:
>>> script_spec_register() called two functions
>>> script_spec__find() and script_spec__findnew().
>>> But script_spec__find() was called two times.
>>>
>>> So remove script_spec__findnew() and make
>>> script_spec_register() only call once script_spec__find().
>>>
>>> Cc: Jiri Olsa <jolsa@kernel.org>
>>> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
>>
>> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> Looks good, applied.
>
> Thanks,
>
> - Arnaldo

Thank you!!

Taeung

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] perf script: Remove duplicated code and needless a script_spec__findnew() Taeung Song <treeze.taeung@gmail.com> - 2016-02-25 16:20 +0100
  Re: [PATCH 3/3] perf script: Remove duplicated code and needless a  script_spec__findnew() Taeung Song <treeze.taeung@gmail.com> - 2016-02-25 20:10 +0100
  Re: [PATCH 3/3] perf script: Remove duplicated code and needless a  script_spec__findnew() Jiri Olsa <jolsa@redhat.com> - 2016-02-25 20:10 +0100
    Re: [PATCH 3/3] perf script: Remove duplicated code and needless a  script_spec__findnew() Taeung Song <treeze.taeung@gmail.com> - 2016-02-25 20:20 +0100
    Re: [PATCH 3/3] perf script: Remove duplicated code and needless a  script_spec__findnew() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-25 20:20 +0100
  [tip:perf/core] perf script: Remove duplicated code and needless  script_spec__findnew() tip-bot for Taeung Song <tipbot@zytor.com> - 2016-02-27 10:50 +0100

csiph-web