Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1343308
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 1/3] perf: generalize perf_callchain |
| Date | 2016-02-25 17:50 +0100 |
| Message-ID | <r67h0-6Ay-5@gated-at.bofh.it> (permalink) |
| References | <r3nV0-87u-5@gated-at.bofh.it> <r3nV0-87u-3@gated-at.bofh.it> <r64VR-50x-39@gated-at.bofh.it> <r677k-6vJ-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Feb 25, 2016 at 08:37:34AM -0800, Alexei Starovoitov wrote: > On 2/25/16 6:18 AM, Peter Zijlstra wrote: > >On Wed, Feb 17, 2016 at 07:58:57PM -0800, Alexei Starovoitov wrote: > >>. avoid walking the stack when there is no room left in the buffer > >>. generalize get_perf_callchain() to be called from bpf helper > > > >If it does two things it should be two patches. > > could have been two patches, but it will only add more churn > to the same lines. what's the concern? It makes review easier, shows which modification is for what purpose. Also the changelog really needs more; it should for example explain what BPF needs from the callchain code, and preferably why.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH net-next 1/3] perf: generalize perf_callchain Peter Zijlstra <peterz@infradead.org> - 2016-02-25 15:20 +0100
Re: [PATCH net-next 1/3] perf: generalize perf_callchain Alexei Starovoitov <ast@fb.com> - 2016-02-25 17:40 +0100
Re: [PATCH net-next 1/3] perf: generalize perf_callchain Peter Zijlstra <peterz@infradead.org> - 2016-02-25 17:50 +0100
Re: [PATCH net-next 1/3] perf: generalize perf_callchain Peter Zijlstra <peterz@infradead.org> - 2016-02-25 17:50 +0100
csiph-web