Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1343327

Re: [PATCH] spi: lp-8841: return correct error code from probe

Show all headers | View raw

On Thu, 2016-02-25 at 12:37 +0100, Arnd Bergmann wrote:
> The spi_lp8841_rtc_probe() function misses an initialization of the
> return code when it fails to get its memory resource, as gcc notices:
> 
> drivers/spi/spi-lp8841-rtc.c: In function 'spi_lp8841_rtc_probe':
> drivers/spi/spi-lp8841-rtc.c:239:9: error: 'ret' may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
> 
> This changes the code to propagate the error from
> devm_ioremap_resource().
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7ecbfff6711f ("spi: master driver to enable RTC on ICPDAS LP-
> 8841")

Tested-by: Sergei Ianovich <ynvich@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] spi: lp-8841: return correct error code from probe Arnd Bergmann <arnd@arndb.de> - 2016-02-25 12:40 +0100
  Re: [PATCH] spi: lp-8841: return correct error code from probe Sergei Ianovich <ynvich@gmail.com> - 2016-02-25 18:10 +0100
  Re: [PATCH] spi: lp-8841: return correct error code from probe Sergei Ianovich <ynvich@gmail.com> - 2016-02-27 20:40 +0100
    Re: [PATCH] spi: lp-8841: return correct error code from probe Arnd Bergmann <arnd@arndb.de> - 2016-02-28 23:10 +0100

csiph-web