Re: [PATCH] ARM: sa1100: make sa1100_register_uart_fns a function

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: sa1100: make sa1100_register_uart_fns a function
Date	2016-02-25 15:40 +0100
Message-ID	<r65fc-59a-13@gated-at.bofh.it> (permalink)
References	<r5mi6-6Kg-15@gated-at.bofh.it> <r63ZN-4iF-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday 25 February 2016 14:18:44 Linus Walleij wrote:
> On Tue, Feb 23, 2016 at 3:34 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > Calling sa1100_register_uart_fns() leaves the port structure
> > unused when CONFIG_SERIAL_SA1100 is disabled, and we get a
> > compiler warning about that:
> >
> > arch/arm/mach-sa1100/badge4.c:317:31: warning: 'badge4_port_fns' defined but not used [-Wunused-variable]
> >  static struct sa1100_port_fns badge4_port_fns __initdata = {
> >
> > This turns the two empty macros into empty inline functions,
> > which has the same effect, but lets the compiler know that the
> > variables are intentionally unused.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> >  include/linux/platform_data/sa11x0-serial.h | 8 ++++++--
> 
> It looks like you should send this to Greg?

Yes, good point.

The file was traditionally under arch/arm (or include/asm-arm before
that), but considering it as part of the driver makes slightly
more sense now.

Sent out with a modified subject and your Ack to Greg now.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: sa1100: make sa1100_register_uart_fns a function Arnd Bergmann <arnd@arndb.de> - 2016-02-23 15:40 +0100
  Re: [PATCH] ARM: sa1100: make sa1100_register_uart_fns a function Linus Walleij <linus.walleij@linaro.org> - 2016-02-25 14:20 +0100
    Re: [PATCH] ARM: sa1100: make sa1100_register_uart_fns a function Arnd Bergmann <arnd@arndb.de> - 2016-02-25 15:40 +0100

csiph-web