Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller

From	Parav Pandit <pandit.parav@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller
Date	2016-02-25 15:30 +0100
Message-ID	<r655w-54N-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <r4dAf-4cj-31@gated-at.bofh.it> <r5Kkp-72Y-7@gated-at.bofh.it> <r5Kkp-72Y-5@gated-at.bofh.it> <r64j7-4qI-3@gated-at.bofh.it> <r64j7-4qI-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Can we call kfree() with spin_lock held? All these years I tend to
> avoid doing so.
Also it doesn't look correct to hold the lock while freeing the memory
which is totally unrelated to the lock.
With that I think current code appears ok with exception that its
duplicated at two place for code readability around lock.
What say?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller Parav Pandit <pandit.parav@gmail.com> - 2016-02-24 17:20 +0100
  Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller Parav Pandit <pandit.parav@gmail.com> - 2016-02-25 14:40 +0100
    Re: [PATCHv6 1/3] rdmacg: Added rdma cgroup controller Parav Pandit <pandit.parav@gmail.com> - 2016-02-25 15:30 +0100

csiph-web