Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1343169

[PATCH 7/9] clockevents/drivers/arm_arch_timer: Implement ->set_state_oneshot_stopped()

Show all headers | View raw

From: Viresh Kumar <viresh.kumar@linaro.org>

set_state_oneshot_stopped() is called by the clkevt core, when the next
event is required at an expiry time of 'KTIME_MAX'. This normally
happens with NO_HZ_{IDLE|FULL} in both LOWRES/HIGHRES modes.

This patch makes the clockevent device to stop on such an event, to
avoid spurious interrupts, as explained by: commit 8fff52fd5093
("clockevents: Introduce CLOCK_EVT_STATE_ONESHOT_STOPPED state").

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/arm_arch_timer.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index 7c567f0..f0dd9d4 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -274,10 +274,12 @@ static void __arch_timer_setup(unsigned type,
 		if (arch_timer_use_virtual) {
 			clk->irq = arch_timer_ppi[VIRT_PPI];
 			clk->set_state_shutdown = arch_timer_shutdown_virt;
+			clk->set_state_oneshot_stopped = arch_timer_shutdown_virt;
 			clk->set_next_event = arch_timer_set_next_event_virt;
 		} else {
 			clk->irq = arch_timer_ppi[PHYS_SECURE_PPI];
 			clk->set_state_shutdown = arch_timer_shutdown_phys;
+			clk->set_state_oneshot_stopped = arch_timer_shutdown_phys;
 			clk->set_next_event = arch_timer_set_next_event_phys;
 		}
 	} else {
@@ -287,10 +289,12 @@ static void __arch_timer_setup(unsigned type,
 		clk->cpumask = cpu_all_mask;
 		if (arch_timer_mem_use_virtual) {
 			clk->set_state_shutdown = arch_timer_shutdown_virt_mem;
+			clk->set_state_oneshot_stopped = arch_timer_shutdown_virt_mem;
 			clk->set_next_event =
 				arch_timer_set_next_event_virt_mem;
 		} else {
 			clk->set_state_shutdown = arch_timer_shutdown_phys_mem;
+			clk->set_state_oneshot_stopped = arch_timer_shutdown_phys_mem;
 			clk->set_next_event =
 				arch_timer_set_next_event_phys_mem;
 		}
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PULL] : clockevents for 4.6 Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-25 14:30 +0100
  [PATCH 3/9] clocksource/drivers/lpc32xx: Don't use the prescaler counter for clockevents Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-25 14:40 +0100
  [PATCH 5/9] clocksource/drivers/lpc32xx: Support timer-based ARM delay Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-25 14:40 +0100
  [PATCH 9/9] clockevents/drivers/exynos_mct: Implement ->set_state_oneshot_stopped() Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-25 14:40 +0100
  [PATCH 2/9] clocksource/drivers/rockchip: Add err handle for rk_timer_init Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-25 14:40 +0100
  [PATCH 1/9] clocksource/drivers/arm_arch_timer: Enable and verify MMIO access Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-25 14:40 +0100
    [PATCH 8/9] clockevents/drivers/arm_global_timer: Implement ->set_state_oneshot_stopped() Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-25 14:40 +0100
      Re: [PATCH 8/9] clockevents/drivers/arm_global_timer: Implement  ->set_state_oneshot_stopped() Jisheng Zhang <jszhang@marvell.com> - 2016-02-26 10:50 +0100
    [PATCH 7/9] clockevents/drivers/arm_arch_timer: Implement ->set_state_oneshot_stopped() Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-25 14:40 +0100
    [PATCH 6/9] clocksource/drivers/arm_global_timer: Register delay timer Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-25 14:40 +0100
    [PATCH 4/9] clocksource/drivers/lpc32xx: Support periodic mode Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-25 14:40 +0100

csiph-web