Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1343186
| From | Torsten Duwe <duwe@lst.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 05/12] powerpc/ftrace: ftrace_graph_caller() needs to save/restore toc |
| Date | 2016-02-25 15:10 +0100 |
| Message-ID | <r64Mb-4WY-29@gated-at.bofh.it> (permalink) |
| References | <r5IBX-5Pl-7@gated-at.bofh.it> <r5ILE-5T6-23@gated-at.bofh.it> <r5S8i-49E-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Feb 25, 2016 at 11:30:38AM +1100, Balbir Singh wrote: > On 25/02/16 01:28, Michael Ellerman wrote: > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > > --- > > arch/powerpc/kernel/entry_64.S | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > Ah, -mprofile-kernel, DYNAMIC_FTRACE but without REGS. Hadn't considered that, thanks! > > > > diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S > > index 2a7313cfbc7d..9e77a2c8f218 100644 > > --- a/arch/powerpc/kernel/entry_64.S > > +++ b/arch/powerpc/kernel/entry_64.S > > @@ -1237,6 +1237,11 @@ _GLOBAL(ftrace_graph_caller) > > std r5, 64(r1) > > std r4, 56(r1) > > std r3, 48(r1) > > + > > + /* Save callee's TOC in the ABI compliant location */ > > + std r2, 24(r1) > R2_STACK_OFFSET for readability? I have encountered LRSAVE vs. PPC_LR_STKOFF and STK_GOT vs. R2_STACK_OFFSET, some usable in assembler source, some in C. > > + ld r2, PACATOC(r13) /* get kernel TOC in r2 */ > > + > > mfctr r4 /* ftrace_caller has moved local addr here */ > > std r4, 40(r1) > > mflr r3 /* ftrace_caller has restored LR from stack */ > > @@ -1262,6 +1267,9 @@ _GLOBAL(ftrace_graph_caller) > > ld r4, 56(r1) > > ld r3, 48(r1) > > > > + /* Restore callee's TOC */ > > + ld r2, 24(r1) > > + > > addi r1, r1, 112 > > mflr r0 > > std r0, LRSAVE(r1) > > Reviewed-by: Balbir Singh <bsingharora@gmail.com> Reviewed-by: Torsten Duwe <duwe@suse.de> Torsten
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 01/12] powerpc/module: Only try to generate the ftrace_caller() stub once Michael Ellerman <mpe@ellerman.id.au> - 2016-02-24 15:30 +0100
[PATCH 02/12] powerpc/module: Mark module stubs with a magic value Michael Ellerman <mpe@ellerman.id.au> - 2016-02-24 15:40 +0100
Re: [PATCH 02/12] powerpc/module: Mark module stubs with a magic value Balbir Singh <bsingharora@gmail.com> - 2016-02-25 01:10 +0100
Re: [PATCH 02/12] powerpc/module: Mark module stubs with a magic value Michael Ellerman <mpe@ellerman.id.au> - 2016-02-25 07:50 +0100
Re: [PATCH 02/12] powerpc/module: Mark module stubs with a magic value Torsten Duwe <duwe@lst.de> - 2016-02-25 14:20 +0100
Re: [PATCH 02/12] powerpc/module: Mark module stubs with a magic value Michael Ellerman <mpe@ellerman.id.au> - 2016-02-26 11:40 +0100
[PATCH 06/12] powerpc/module: Rework is_early_mcount_callsite() Michael Ellerman <mpe@ellerman.id.au> - 2016-02-24 15:40 +0100
Re: [PATCH 06/12] powerpc/module: Rework is_early_mcount_callsite() Balbir Singh <bsingharora@gmail.com> - 2016-02-25 00:40 +0100
Re: [PATCH 06/12] powerpc/module: Rework is_early_mcount_callsite() Michael Ellerman <mpe@ellerman.id.au> - 2016-02-25 11:30 +0100
Re: [PATCH 06/12] powerpc/module: Rework is_early_mcount_callsite() Torsten Duwe <duwe@lst.de> - 2016-02-25 15:10 +0100
[PATCH 05/12] powerpc/ftrace: ftrace_graph_caller() needs to save/restore toc Michael Ellerman <mpe@ellerman.id.au> - 2016-02-24 15:40 +0100
Re: [PATCH 05/12] powerpc/ftrace: ftrace_graph_caller() needs to save/restore toc Balbir Singh <bsingharora@gmail.com> - 2016-02-25 01:40 +0100
Re: [PATCH 05/12] powerpc/ftrace: ftrace_graph_caller() needs to save/restore toc Michael Ellerman <mpe@ellerman.id.au> - 2016-02-25 11:50 +0100
Re: [PATCH 05/12] powerpc/ftrace: ftrace_graph_caller() needs to save/restore toc Torsten Duwe <duwe@lst.de> - 2016-02-25 15:10 +0100
[PATCH 10/12] powerpc/ftrace: FTRACE_WITH_REGS configuration variables Michael Ellerman <mpe@ellerman.id.au> - 2016-02-24 15:40 +0100
Re: [PATCH 10/12] powerpc/ftrace: FTRACE_WITH_REGS configuration variables Balbir Singh <bsingharora@gmail.com> - 2016-02-25 02:20 +0100
Re: [PATCH 10/12] powerpc/ftrace: FTRACE_WITH_REGS configuration variables Torsten Duwe <duwe@lst.de> - 2016-02-25 15:40 +0100
[PATCH 07/12] powerpc/ftrace: FTRACE_WITH_REGS implementation for ppc64le Michael Ellerman <mpe@ellerman.id.au> - 2016-02-24 15:40 +0100
Re: [PATCH 07/12] powerpc/ftrace: FTRACE_WITH_REGS implementation for ppc64le Balbir Singh <bsingharora@gmail.com> - 2016-02-25 01:50 +0100
Re: [PATCH 07/12] powerpc/ftrace: FTRACE_WITH_REGS implementation for ppc64le Torsten Duwe <duwe@lst.de> - 2016-02-25 16:20 +0100
Re: [PATCH 07/12] powerpc/ftrace: FTRACE_WITH_REGS implementation for ppc64le Michael Ellerman <mpe@ellerman.id.au> - 2016-02-26 11:20 +0100
[PATCH 09/12] powerpc/ftrace: Use generic ftrace_modify_all_code() Michael Ellerman <mpe@ellerman.id.au> - 2016-02-24 15:40 +0100
Re: [PATCH 09/12] powerpc/ftrace: Use generic ftrace_modify_all_code() Balbir Singh <bsingharora@gmail.com> - 2016-02-25 02:20 +0100
[PATCH 03/12] powerpc/module: Create a special stub for ftrace_caller() Michael Ellerman <mpe@ellerman.id.au> - 2016-02-24 15:40 +0100
Re: [PATCH 03/12] powerpc/module: Create a special stub for ftrace_caller() Balbir Singh <bsingharora@gmail.com> - 2016-02-25 01:10 +0100
Re: [PATCH 03/12] powerpc/module: Create a special stub for ftrace_caller() Michael Ellerman <mpe@ellerman.id.au> - 2016-02-25 11:50 +0100
Re: [PATCH 03/12] powerpc/module: Create a special stub for ftrace_caller() Torsten Duwe <duwe@lst.de> - 2016-02-25 14:40 +0100
Re: [PATCH 03/12] powerpc/module: Create a special stub for ftrace_caller() Michael Ellerman <mpe@ellerman.id.au> - 2016-02-26 11:40 +0100
Re: [PATCH 01/12] powerpc/module: Only try to generate the ftrace_caller() stub once Balbir Singh <bsingharora@gmail.com> - 2016-02-25 01:00 +0100
Re: [PATCH 01/12] powerpc/module: Only try to generate the ftrace_caller() stub once Balbir Singh <bsingharora@gmail.com> - 2016-02-25 05:40 +0100
Re: [PATCH 01/12] powerpc/module: Only try to generate the ftrace_caller() stub once Torsten Duwe <duwe@lst.de> - 2016-02-25 14:10 +0100
Re: [PATCH 01/12] powerpc/module: Only try to generate the ftrace_caller() stub once Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> - 2016-02-25 15:40 +0100
csiph-web