[PATCH] xfs: remove impossible condition

From	Luis de Bethencourt <luisbg@osg.samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH] xfs: remove impossible condition
Date	2016-02-25 13:50 +0100
Message-ID	<r63wJ-3Qd-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

bp_release is set to 0 just before the breakpoint of the for loop before
the conditional check (in line 458). The other breakpoint is a goto that
skips the dead code.

Addresses-Coverity-Id: 102338

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---

Hi,

Thanks for reviewing this :)

Luis

 fs/xfs/libxfs/xfs_bmap.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index 6a05166..1171795 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -477,10 +477,7 @@ xfs_bmap_check_leaf_extents(
 		}
 		block = XFS_BUF_TO_BLOCK(bp);
 	}
-	if (bp_release) {
-		bp_release = 0;
-		xfs_trans_brelse(NULL, bp);
-	}
+
 	return;
 
 error0:
-- 
2.5.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] xfs: remove impossible condition Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-02-25 13:50 +0100
  Re: [PATCH] xfs: remove impossible condition Christoph Hellwig <hch@infradead.org> - 2016-03-01 13:10 +0100
    Re: [PATCH] xfs: remove impossible condition Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-03-01 14:30 +0100
      Re: [PATCH] xfs: remove impossible condition Christoph Hellwig <hch@infradead.org> - 2016-03-01 19:30 +0100

csiph-web