Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1341204

Re: [PATCH RESEND 1/2] usb: dwc2: Move register save and restore functions

From Doug Anderson <dianders@chromium.org>
Newsgroups linux.kernel
Subject Re: [PATCH RESEND 1/2] usb: dwc2: Move register save and restore functions
Date 2016-02-24 01:30 +0100
Message-ID <r5vv4-4S2-5@gated-at.bofh.it> (permalink)
References <r5sQy-2Oz-11@gated-at.bofh.it> <r5sQy-2Oz-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


John,

On Tue, Feb 23, 2016 at 1:33 PM, John Youn <johnyoun@synopsys.com> wrote:
> Move the register save and restore functions into the host and gadget
> specific files.
>
> Signed-off-by: John Youn <johnyoun@synopsys.com>
> ---
>  drivers/usb/dwc2/core.c   | 183 ----------------------------------------------
>  drivers/usb/dwc2/core.h   |  13 ++++
>  drivers/usb/dwc2/gadget.c | 102 ++++++++++++++++++++++++++
>  drivers/usb/dwc2/hcd.c    |  64 ++++++++++++++++
>  4 files changed, 179 insertions(+), 183 deletions(-)

I picked these back to my chromeos-3.14 kernel (with many many dwc2
backports) and I confirmed that I can still compile the kernel, boot
it, and use USB.  I also confirmed no warnings were introduced for me.
I'm only testing HOST, not gadget mode.

I also reviewed the code and agree that it looks good.  Thanks!

Tested-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH RESEND 1/2] usb: dwc2: Move register save and restore functions John Youn <johnyoun@synopsys.com> - 2016-02-23 22:40 +0100
  Re: [PATCH RESEND 1/2] usb: dwc2: Move register save and restore functions Doug Anderson <dianders@chromium.org> - 2016-02-24 01:30 +0100

csiph-web