Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1341171

Re: [PATCH] ipv4: in new netns initialize sysctls in net.ipv4.conf.* with defaults

Show all headers | View raw

From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Date: Sun, 21 Feb 2016 10:11:02 +0300

> Currently initial net.ipv4.conf.all.* and net.ipv4.conf.default.* are
> copied from init network namespace because static structures are used
> for init_net. This makes no sense because new netns might be created
> from any netns. This patch makes private copy also for init netns if
> network namespaces are enabled. Other sysctls in net.ipv4 and net.ipv6
> already initialized with default values at namespace creation.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> Fixes: 752d14dc6aa9 ("[IPV4]: Move the devinet pointers on the struct net")

The horse has long left the stable on this.  We cannot change this now
without breaking things.

Imagine someone who intentionally sets up init_net with a certain set
of settings and expects them to propagate into every created namespace.

We'll break things for them and given the behavior existed for so long
what the administrator is doing is very reasonable.

I'm not applying this sorry, we are stuck with the current behavior
whether we like it or not.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ipv4: in new netns initialize sysctls in  net.ipv4.conf.* with defaults David Miller <davem@davemloft.net> - 2016-02-24 00:30 +0100
  Re: [PATCH] ipv4: in new netns initialize sysctls in net.ipv4.conf.*  with defaults Konstantin Khlebnikov <koct9i@gmail.com> - 2016-02-24 06:20 +0100
    Re: [PATCH] ipv4: in new netns initialize sysctls in  net.ipv4.conf.* with defaults David Miller <davem@davemloft.net> - 2016-02-24 16:30 +0100
  Re: [PATCH] ipv4: in new netns initialize sysctls in net.ipv4.conf.* with defaults ebiederm@xmission.com (Eric W. Biederman) - 2016-02-24 23:20 +0100
    Re: [PATCH] ipv4: in new netns initialize sysctls in net.ipv4.conf.*  with defaults Nicolas Dichtel <nicolas.dichtel@6wind.com> - 2016-02-25 15:30 +0100
      Re: [PATCH] ipv4: in new netns initialize sysctls in  net.ipv4.conf.* with defaults David Miller <davem@davemloft.net> - 2016-02-25 17:50 +0100

csiph-web