Re: [PATCH net v3] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

From	Francois Romieu <romieu@fr.zoreil.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net v3] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.
Date	2016-02-23 23:50 +0100
Message-ID	<r5tWi-3Ha-1@gated-at.bofh.it> (permalink)
References	<r5gw2-2Ej-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Chunhao Lin <hau@realtek.com> :
[...]
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 537974c..404be51 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
[...]
> @@ -7853,6 +7859,11 @@ static int rtl8169_runtime_suspend(struct device *device)
>  
>  	rtl8169_net_suspend(dev);
>  
> +	/* Update counters before going runtime suspend */
> +	if (netif_running(dev))

This test is useless (always true):

- rtl_open
  [...]
  pm_runtime_get_sync(&pdev->dev);
  [...]
  tp->TxDescArray = blah
  [...]

- rtl8169_close
  [...]
  pm_runtime_get_sync(&pdev->dev);
  [...]
  tp->TxDescArray = NULL;

- rtl8169_runtime_suspend
  [...]
  if (!tp->TxDescArray)
  	  return 0;

(the implicit smp barriers are mildly obvious, ok)

-- 
Ueimor

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net v3] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam. Chunhao Lin <hau@realtek.com> - 2016-02-23 09:30 +0100
  Re: [PATCH net v3] r8169:fix "rtl_counters_cond == 1 (loop: 1000,  delay: 10)" log spam. Francois Romieu <romieu@fr.zoreil.com> - 2016-02-23 23:50 +0100

csiph-web