[PATCH 3.2 22/67] perf annotate browser: Fix behaviour of Shift-Tab with nothing focussed

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Ben Hutchings <ben@decadent.org.uk>
Newsgroups	linux.kernel
Subject	[PATCH 3.2 22/67] perf annotate browser: Fix behaviour of Shift-Tab with nothing focussed
Date	Tue, 23 Feb 2016 22:50:03 +0100
Message-ID	<r5t0f-2Ub-23@gated-at.bofh.it> (permalink)
References	<r5t0e-2Ub-3@gated-at.bofh.it>
Content-Type	text/plain; charset="UTF-8"
Content-Disposition	inline
Content-Transfer-Encoding	8bit
MIME-Version	1.0
X-Mailer	LinuxStableQueue (scripts by bwh)
X-Sa-Exim-Connect-IP	92.40.248.141
X-Sa-Exim-Mail-From	ben@decadent.org.uk
X-Sa-Exim-Scanned	No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	akpm@linux-foundation.org, "Matt Fleming" <matt@codeblueprint.co.uk>, "Arnaldo Carvalho de Melo" <acme@redhat.com>, "Peter Zijlstra" <peterz@infradead.org>, "Markus Trippelsdorf" <markus@trippelsdorf.de>, "Ingo Molnar" <mingo@kernel.org>
X-Original-Date	Tue, 23 Feb 2016 21:42:03 +0000
X-Original-Message-ID	<lsq.1456263723.486980424@decadent.org.uk>
X-Original-References	<lsq.1456263722.390955919@decadent.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1341054

Show key headers only | View raw

3.2.78-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Markus Trippelsdorf <markus@trippelsdorf.de>

commit d4913cbd05bab685e49c8174896e563b2487d054 upstream.

The issue was pointed out by gcc-6's -Wmisleading-indentation.

Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Acked-by: Ingo Molnar <mingo@kernel.org>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: c97cf42219b7 ("perf top: Live TUI Annotation")
Link: http://lkml.kernel.org/r/20151214154403.GB1409@x4
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
[bwh: Backported to 3.2: adjust filename, context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 tools/perf/util/ui/browsers/annotate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/tools/perf/util/ui/browsers/annotate.c
+++ b/tools/perf/util/ui/browsers/annotate.c
@@ -276,11 +276,11 @@ static int annotate_browser__run(struct
 				nd = self->curr_hot;
 			break;
 		case K_UNTAB:
-			if (nd != NULL)
+			if (nd != NULL) {
 				nd = rb_next(nd);
 				if (nd == NULL)
 					nd = rb_first(&self->entries);
-			else
+			} else
 				nd = self->curr_hot;
 			break;
 		case 'H':

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 3.2 22/67] perf annotate browser: Fix behaviour of  Shift-Tab with nothing focussed Ben Hutchings <ben@decadent.org.uk> - 2016-02-23 22:50 +0100

csiph-web