Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340941

Re: [PATCH] arm64: dts: msm8916: Move smem below hwlock

Show all headers | View raw

On 23.02.16 г. 19:29, Srinivas Kandagatla wrote:
> 
> 
> On 23/02/16 17:21, Georgi Djakov wrote:
>> When the SMEM is probed it defers as it depends on the hardware lock, which
>> is not available yet. But the SMD bus and RPM regulators and clocks depend
>> on SMEM and they defer too. The problem with this is that the order of
>> registering the devices is not optimal and also we may end with messed
>> up serial console as the RPM clocks are not registered yet..
> I noticed the same issue but was wondering why would we end up with messed up serial console?
> 
> Could you add more details on why serial console is messed up?
> 
> I thought, serial driver has nothing to do with the rpm clocks directly!
> 

If we don't have the rpm clocks registered, the uart clock is an orphan
and when clk_get_rate() is called on orphan clocks it returns 0 as rate.
In our case the msm_serial driver calls clk_get_rate() and gets 0 rate
as the parent rpm clock has not registered yet. The result is that the
baudrate is set incorrectly.

BR,
Georgi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] arm64: dts: msm8916: Move smem below hwlock Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-02-23 18:30 +0100
  Re: [PATCH] arm64: dts: msm8916: Move smem below hwlock Georgi Djakov <georgi.djakov@linaro.org> - 2016-02-23 19:50 +0100
    Re: [PATCH] arm64: dts: msm8916: Move smem below hwlock Andy Gross <andy.gross@linaro.org> - 2016-02-23 20:10 +0100
      Re: [PATCH] arm64: dts: msm8916: Move smem below hwlock Georgi Djakov <georgi.djakov@linaro.org> - 2016-02-24 11:40 +0100
    Re: [PATCH] arm64: dts: msm8916: Move smem below hwlock Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-02-23 20:30 +0100
      Re: [PATCH] arm64: dts: msm8916: Move smem below hwlock Georgi Djakov <georgi.djakov@linaro.org> - 2016-02-23 21:20 +0100

csiph-web