Re: [PATCH] tty: audit: remove unused variable

From	Peter Hurley <peter@hurleysoftware.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tty: audit: remove unused variable
Date	2016-02-23 17:10 +0100
Message-ID	<r5nHb-7N8-5@gated-at.bofh.it> (permalink)
References	<r5gFI-2J4-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Sudip,

On 02/23/2016 12:30 AM, Sudip Mukherjee wrote:
> While building with W=1 we were getting build warning:
> drivers/tty/tty_audit.c:149:16: warning: variable 'sessionid' set but not used
> 
> The local variable sessionid was only assigned the value of
> current->sessionid but was never reused.

Thanks for catching this.

While reviewing this patch, I noticed entire if clause can be reduced to

	if (audit_enabled)
		tty_audit_log("ioctl=TIOCSTI", dev, &ch, 1);

since auid is unused variable as well.

Regards,
Peter Hurley


> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>  drivers/tty/tty_audit.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/tty/tty_audit.c b/drivers/tty/tty_audit.c
> index 66d53fc..81fe3fb 100644
> --- a/drivers/tty/tty_audit.c
> +++ b/drivers/tty/tty_audit.c
> @@ -146,10 +146,8 @@ void tty_audit_tiocsti(struct tty_struct *tty, char ch)
>  
>  	if (audit_enabled) {
>  		kuid_t auid;
> -		unsigned int sessionid;
>  
>  		auid = audit_get_loginuid(current);
> -		sessionid = audit_get_sessionid(current);
>  		tty_audit_log("ioctl=TIOCSTI", dev, &ch, 1);
>  	}
>  }
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tty: audit: remove unused variable Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-23 09:40 +0100
  Re: [PATCH] tty: audit: remove unused variable Peter Hurley <peter@hurleysoftware.com> - 2016-02-23 17:10 +0100

csiph-web