Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340737

Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio

Show all headers | View raw

On Tuesday 23 February 2016 14:42:55 Marc Dietrich wrote:
> Am Dienstag, 23. Februar 2016, 14:17:17 CET schrieb Arnd Bergmann:
> > On Tuesday 23 February 2016 11:38:52 Marc Dietrich wrote:
> > > Am Dienstag, 23. Februar 2016, 11:31:40 CET schrieb Arnd Bergmann:
> > Ah, so the problem of attaching DT properties to a USB device has recently
> > been solved, see subject "USB: core: let USB device know device node".
> > 
> > Would that work for you? With this, the USB driver can simply look at
> > the optional DT properties of the USB function to implement its rfkill
> > callbacks.
> 
> oh, that looks indeed interesting. The question is now if rfkill is a property 
> of a device or a subdevice itself. The latter one would only require addition 
> of device-tree instantiation of rfkill, while with the former one, the (or 
> all) usb driver(s) need to be modified to accept device tree properties, 
> especially gpios. The driver would then be responsible to add an rfkill 
> "device".
> 
> IMHO (and unfortunately), it's just a property (a way to specify the relevant 
> gpios), making the solution again hard to archive.

Does rfkill always have a separate device in the Linux driver model?

I would say that if we standardize on the property names, we can
have some generic helper code that does everything with one or
two function calls, similar to how we can read a mac address from
a DT node from ROM-less USB ethernet devices.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio Arnd Bergmann <arnd@arndb.de> - 2016-02-23 11:20 +0100
  Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio Arnd Bergmann <arnd@arndb.de> - 2016-02-23 11:40 +0100
    Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio Marc Dietrich <marvin24@gmx.de> - 2016-02-23 11:40 +0100
      Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio Arnd Bergmann <arnd@arndb.de> - 2016-02-23 14:20 +0100
        Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio Marc Dietrich <marvin24@gmx.de> - 2016-02-23 14:50 +0100
          Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio Arnd Bergmann <arnd@arndb.de> - 2016-02-23 16:10 +0100
            Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with  rfkill_gpio Johannes Berg <johannes@sipsolutions.net> - 2016-02-23 21:40 +0100

csiph-web