Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1340599

Re: [PATCH] sched/deadline: Always calculate end of period on sched_yield()

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [PATCH] sched/deadline: Always calculate end of period on sched_yield()
Date 2016-02-23 14:20 +0100
Message-ID <r5l2G-5VT-11@gated-at.bofh.it> (permalink)
References <r1vai-5dV-11@gated-at.bofh.it> <r5kgi-5mq-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 23 Feb 2016 13:28:22 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, Feb 12, 2016 at 06:10:20PM -0500, Steven Rostedt wrote:
> > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> > index cd64c979d0e1..1dd180cda574 100644
> > --- a/kernel/sched/deadline.c
> > +++ b/kernel/sched/deadline.c
> > @@ -735,7 +735,7 @@ static void update_curr_dl(struct rq *rq)
> >  	 * approach need further study.
> >  	 */
> >  	delta_exec = rq_clock_task(rq) - curr->se.exec_start;
> > -	if (unlikely((s64)delta_exec <= 0))
> > +	if (unlikely((s64)delta_exec <= 0 && !dl_se->dl_yielded))
> >  		return;
> >  
> >  	schedstat_set(curr->se.statistics.exec_max,  
> 
> 
> Would something like this make sense instead?
> 

I'll test it and see if it works.

-- Steve

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] sched/deadline: Always calculate end of period on  sched_yield() Peter Zijlstra <peterz@infradead.org> - 2016-02-23 13:30 +0100
  Re: [PATCH] sched/deadline: Always calculate end of period on  sched_yield() Steven Rostedt <rostedt@goodmis.org> - 2016-02-23 14:20 +0100
  Re: [PATCH] sched/deadline: Always calculate end of period on  sched_yield() Steven Rostedt <rostedt@goodmis.org> - 2016-02-23 16:10 +0100
  [tip:sched/core] sched/deadline: Always calculate end of period on  sched_yield() tip-bot for Peter Zijlstra <tipbot@zytor.com> - 2016-02-29 12:20 +0100

csiph-web