Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1340569
| From | Sergei Ianovich <ynvich@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb |
| Date | 2016-02-23 13:10 +0100 |
| Message-ID | <r5jWW-5br-9@gated-at.bofh.it> (permalink) |
| References | <r4Wxl-4RK-61@gated-at.bofh.it> <r50KC-7Jl-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Robert,
On Mon, 2016-02-22 at 16:35 +0100, Robert Jarzmik wrote:
> You're right, I haven't seen the pxa2xx.dtsi statement before.
>
> As such, could you amend a bit your patch please to :
> - add:
> Fixes: 0ec1939668e5 ("ARM: dts: pxa: add the usb host controller")
> - make the same change in pxa3xx.dtsi, as the same error is there
> - and more globally align pxa2xx.dtsi, pxa27x.dtsi and pxa3xx.dtsi
> - remove the compatible, reg, interrupts and status from both pxa27x.dtsi and
> pxa3xx.dtsi as they are redundant with the included pxa2xxx.dsti one
No problem. Let's figure out the best approach.
> I'm even wondering if the proper change wouldn't be to scrap the ohci
> declarations from pxa27x.dtsi and pxa3xx.dtsi, and only add the "clocks"
> property to pxa2xx.dtsi ...
Since clocks are declared in pxa27x.dtsi and pxa3xx.dtsi, there is a
stronger ground to have node clocks properties set in pxa27x.dtsi
and pxa3xx.dtsi as well. However, there is already nodes with clocks
properties in pxa2xx.dtsi.
I cannot choose, you should make a decision.
--
Sergei Ianovich <ynvich@gmail.com>
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb Sergei Ianovich <ynvich@gmail.com> - 2016-02-23 13:10 +0100 Re: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-23 21:20 +0100
csiph-web