Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340548

Re: [PATCH] Staging: comedi: mite: added spaces around | and *

Show all headers | View raw

On 23/02/16 00:37, Joe Perches wrote:
> On Tue, 2016-02-23 at 00:38 +0100, Philippe Loctaux wrote:
>> Added spaces around | and *, fixing 2 checkpatch checks.
> []
>> diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
> []
>> @@ -51,7 +51,7 @@
>>
>>   #include "mite.h"
>>
>> -#define TOP_OF_PAGE(x) ((x)|(~(PAGE_MASK)))
>> +#define TOP_OF_PAGE(x) ((x) | (~(PAGE_MASK)))
>
> It'd be nice to remove superfluous parentheses here too
>
> +#define TOP_OF_PAGE(x) ((x) | ~PAGE_MASK)
>

Even better: just remove the macro, as it isn't used.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: comedi: mite: added spaces around | and * Philippe Loctaux <phil@philippeloctaux.com> - 2016-02-23 00:40 +0100
  Re: [PATCH] Staging: comedi: mite: added spaces around | and * Joe Perches <joe@perches.com> - 2016-02-23 01:40 +0100
    Re: [PATCH] Staging: comedi: mite: added spaces around | and * Ian Abbott <abbotti@mev.co.uk> - 2016-02-23 12:10 +0100
      Re: [PATCH] Staging: comedi: mite: added spaces around | and * Philippe Loctaux <phil@philippeloctaux.com> - 2016-02-23 15:00 +0100
        Re: [PATCH] Staging: comedi: mite: added spaces around | and * Ian Abbott <abbotti@mev.co.uk> - 2016-02-23 17:40 +0100
  Re: [PATCH] Staging: comedi: mite: added spaces around | and * Ian Abbott <abbotti@mev.co.uk> - 2016-02-23 17:50 +0100
    Re: [PATCH] Staging: comedi: mite: added spaces around | and * Philippe Loctaux <phil@philippeloctaux.com> - 2016-02-24 00:10 +0100

csiph-web