Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340495

Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle period

Show all headers | View raw

On 02/23/2016 11:06 AM, Shreyas B Prabhu wrote:
>
>
> On 02/16/2016 09:13 PM, Daniel Lezcano wrote:
> [...]
>> +	if (index < 0) {
>> +		/*
>> +		 * No idle callbacks fulfilled the constraints, jump
>> +		 * to the default function like there wasn't any
>> +		 * cpuidle driver.
>> +		 */
>> +		goto default_idle;
>> +	} else {
>> +		/*
>> +		 * Enter the idle state previously returned by the
>> +		 * governor decision.  This function will block until
>> +		 * an interrupt occurs and will take care of
>> +		 * re-enabling the local interrupts
>> +		 */
>> +		return cpuidle_enter(drv, dev, index);
>
> Minor point. You are not calling rcu_idle_exit() in else block. This
> should probably be
> 		ret = cpuidle_enter(drv, dev, index);
>                  goto out;

Yes. Right.

Thanks for the review.

   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V3 1/2] irq: Track the interrupt timings Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-16 16:50 +0100
  [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle period Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-16 16:50 +0100
    Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle  period Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-16 17:50 +0100
      Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle period "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-18 00:10 +0100
        Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle period "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-18 00:30 +0100
          Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle  period Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-18 11:30 +0100
            Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle period "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-18 21:00 +0100
              Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle  period Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-19 16:10 +0100
                Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle period "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-20 00:50 +0100
                Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle  period Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-23 10:50 +0100
    Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle  period Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> - 2016-02-22 16:10 +0100
      Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle  period Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-22 18:30 +0100
        Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle  period Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> - 2016-02-23 11:10 +0100
    Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle  period Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> - 2016-02-23 11:10 +0100
      Re: [PATCH V3 2/2] sched: idle: IRQ based next prediction for idle  period Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-23 11:20 +0100
  Re: [PATCH V3 1/2] irq: Track the interrupt timings Nicolas Pitre <nicolas.pitre@linaro.org> - 2016-02-16 17:50 +0100
  Re: [PATCH V3 1/2] irq: Track the interrupt timings Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> - 2016-02-22 15:50 +0100
    Re: [PATCH V3 1/2] irq: Track the interrupt timings Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-22 18:30 +0100

csiph-web