Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340410

Re: [PATCH] irqchip/gicv3-its: Don't allow devices whose ID is outside range

Show all headers | View raw

On 23/02/16 03:57, Shanker Donthineni wrote:
> We are not checking whether the requested device identifier fits into
> table or not. The ITS MAPD command fails if 'Device ID' is outside of
> device table range.
> 
> Add a simple validation check to avoid MAPD failures since we are
> not handling ITS command errors. This change also helps to return an
> error -ENOMEM instead of success to caller.
> 

In which circumstances do you see this failing? We allocate memory for
the whole DevID range (as advertised by the ITS), so anything that comes
up outside of that range cannot be handled anyway, and is a HW
integration issue. You might as well pretend that these devices do not
exist.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] irqchip/gicv3-its: Don't allow devices whose ID is outside range Shanker Donthineni <shankerd@codeaurora.org> - 2016-02-23 05:00 +0100
  Re: [PATCH] irqchip/gicv3-its: Don't allow devices whose ID is  outside range Marc Zyngier <marc.zyngier@arm.com> - 2016-02-23 10:00 +0100
    Re: [PATCH] irqchip/gicv3-its: Don't allow devices whose ID is  outside range Shanker Donthineni <shankerd@codeaurora.org> - 2016-02-23 15:20 +0100
    Re: [PATCH] irqchip/gicv3-its: Don't allow devices whose ID is  outside range Shanker Donthineni <shankerd@codeaurora.org> - 2016-02-23 18:50 +0100
  Re: [PATCH] irqchip/gicv3-its: Don't allow devices whose ID is  outside range Shanker Donthineni <shankerd@codeaurora.org> - 2016-02-23 18:40 +0100

csiph-web