RE: [PATCH net v2] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.

From	Hau <hau@realtek.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH net v2] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam.
Date	2016-02-23 09:00 +0100
Message-ID	<r5g30-2aF-5@gated-at.bofh.it> (permalink)
References	<r50rf-7B2-3@gated-at.bofh.it> <r57VM-4Xh-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Nits:
> 
> - the tp->TxDescArray test provides the required synchronization: see
>   rtl8169_{open/close} and their pm_runtime_{get / put}.
> 
> - ioaddr is not really needed : tp->mmio_addr appears only once and it does
>   not mess the 72..80 cols limit.
> 
> - even if the device can only be automatically runtime suspended some time
>   after a link down event, you may address davem's point regarding stats
>   reliability and move rtl8169_rx_missed + rtl8169_update_counters after
>   rtl8169_net_suspend.

I will submit the new patch according to your advice.

Thanks.

Please consider the environment before printing this e-mail.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net v2] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam. Chunhao Lin <hau@realtek.com> - 2016-02-22 16:20 +0100
  Re: [PATCH net v2] r8169:fix "rtl_counters_cond == 1 (loop: 1000,  delay: 10)" log spam. Francois Romieu <romieu@fr.zoreil.com> - 2016-02-23 00:20 +0100
    RE: [PATCH net v2] r8169:fix "rtl_counters_cond == 1 (loop: 1000, delay: 10)" log spam. Hau <hau@realtek.com> - 2016-02-23 09:00 +0100

csiph-web