Re: [PATCH 3/6] perf, tools, stat: Support metrics in --per-core/socket mode

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/6] perf, tools, stat: Support metrics in --per-core/socket mode
Date	2016-02-23 08:40 +0100
Message-ID	<r5fJD-23t-1@gated-at.bofh.it> (permalink)
References	<r3j4Z-4A2-11@gated-at.bofh.it> <r3j51-4A2-45@gated-at.bofh.it> <r4FZy-Tg-47@gated-at.bofh.it> <r5202-eH-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 22, 2016 at 05:52:02PM +0100, Andi Kleen wrote:
> On Sun, Feb 21, 2016 at 06:15:35PM +0100, Jiri Olsa wrote:
> > On Wed, Feb 17, 2016 at 02:44:02PM -0800, Andi Kleen wrote:
> > 
> > SNIP
> > 
> > > @@ -892,7 +908,10 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval,
> > >  	struct perf_stat_output_ctx out;
> > >  	struct outstate os = {
> > >  		.fh = stat_config.output,
> > > -		.prefix = prefix ? prefix : ""
> > > +		.prefix = prefix ? prefix : "",
> > > +		.id = id,
> > > +		.nr = nr,
> > > +		.evsel = counter,
> > >  	};
> > >  	print_metric_t pm = print_metric_std;
> > >  	void (*nl)(void *);
> > > @@ -962,15 +981,38 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval,
> > >  
> > >  	perf_stat__print_shadow_stats(counter, uval,
> > >  				stat_config.aggr_mode == AGGR_GLOBAL ? 0 :
> > > -				cpu_map__id_to_cpu(id),
> > > +				first_shadow_cpu(counter, id),
> > 
> > hum, IIUC you need to handle AGGR_NONE in here as well?
> 
> AFAIK it works. aggr_get_id in first_shadow_cpu and cpu_map__id_to_cpu
> handle this case, right?

it does not look like.. however it'll be more clear once
there's the doc/comment about used cpus for aggr modes
I asked for in here:

  http://marc.info/?l=linux-kernel&m=145607533503803&w=2

thanks,
jirka

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/6] perf, tools, stat: Support metrics in --per-core/socket mode Andi Kleen <andi@firstfloor.org> - 2016-02-17 23:50 +0100
  Re: [PATCH 3/6] perf, tools, stat: Support metrics in  --per-core/socket mode Jiri Olsa <jolsa@redhat.com> - 2016-02-21 18:20 +0100
  Re: [PATCH 3/6] perf, tools, stat: Support metrics in  --per-core/socket mode Jiri Olsa <jolsa@redhat.com> - 2016-02-21 18:30 +0100
    Re: [PATCH 3/6] perf, tools, stat: Support metrics in  --per-core/socket mode Andi Kleen <andi@firstfloor.org> - 2016-02-27 01:00 +0100
  Re: [PATCH 3/6] perf, tools, stat: Support metrics in  --per-core/socket mode Jiri Olsa <jolsa@redhat.com> - 2016-02-21 18:30 +0100
    Re: [PATCH 3/6] perf, tools, stat: Support metrics in  --per-core/socket mode Andi Kleen <andi@firstfloor.org> - 2016-02-22 18:00 +0100
      Re: [PATCH 3/6] perf, tools, stat: Support metrics in  --per-core/socket mode Jiri Olsa <jolsa@redhat.com> - 2016-02-23 08:40 +0100

csiph-web