Re: [PATCH] firmware: fw_cfg register offsets on supported architectures only

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] firmware: fw_cfg register offsets on supported architectures only
Date	Tue, 23 Feb 2016 06:10:02 +0100
Message-ID	<r5dou-s7-7@gated-at.bofh.it> (permalink)
References	<r563E-3jn-33@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.27
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	gregkh@linuxfoundation.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, arnd@arndb.de, lersek@redhat.com, ralf@linux-mips.org, rmk+kernel@arm.linux.org.uk, eric@anholt.net, hanjun.guo@linaro.org, zajec5@gmail.com, sudeep.holla@arm.com, agross@codeaurora.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, qemu-devel@nongnu.org, imammedo@redhat.com, peter.maydell@linaro.org, leif.lindholm@linaro.org, ard.biesheuvel@linaro.org, pbonzini@redhat.com, kraxel@redhat.com, ehabkost@redhat.com, luto@amacapital.net, stefanha@gmail.com, revol@free.fr, matt@codeblueprint.co.uk, rth@twiddle.net
X-Original-Date	Tue, 23 Feb 2016 07:08:07 +0200
X-Original-Message-ID	<20160223070757-mutt-send-email-mst@redhat.com>
X-Original-References	<20160222211818.GJ16357@HEDWIG.INI.CMU.EDU>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1340303

Show key headers only | View raw

On Mon, Feb 22, 2016 at 04:18:18PM -0500, Gabriel Somlo wrote:
> Refrain from defining default fw_cfg register offsets on
> unsupported architectures -- throw an error instead. If
> QEMU were to add fw_cfg support on additional architectures,
> we should add them to the FW_CFG_SYSFS depends statement in
> drivers/firmware/Kconfig, and provide default values for
> register offsets in drivers/firmware/qemu_fw_cfg.c at that
> time.
> 
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Gabriel Somlo <somlo@cmu.edu>

Acked-by: Michael S. Tsirkin <mst@redhat.com>


> ---
>  drivers/firmware/qemu_fw_cfg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index fedbff5..79f6b7b 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -109,9 +109,7 @@ static void fw_cfg_io_cleanup(void)
>  #  define FW_CFG_CTRL_OFF 0x00
>  #  define FW_CFG_DATA_OFF 0x01
>  # else
> -#  warning "QEMU FW_CFG may not be available on this architecture!"
> -#  define FW_CFG_CTRL_OFF 0x00
> -#  define FW_CFG_DATA_OFF 0x01
> +#  error "QEMU FW_CFG not available on this architecture!"
>  # endif
>  #endif
>  
> -- 
> 2.4.3

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] firmware: fw_cfg register offsets on supported architectures  only Gabriel Somlo <somlo@cmu.edu> - 2016-02-22 22:20 +0100
  Re: [PATCH] firmware: fw_cfg register offsets on supported  architectures only "Michael S. Tsirkin" <mst@redhat.com> - 2016-02-23 06:10 +0100

csiph-web