Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1340247

Re: [PATCH v3 04/11] KVM: page track: add the framework of guest page tracking

From Xiao Guangrong <guangrong.xiao@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3 04/11] KVM: page track: add the framework of guest page tracking
Date 2016-02-23 05:10 +0100
Message-ID <r5csr-8gx-43@gated-at.bofh.it> (permalink)
References <r23lD-25X-3@gated-at.bofh.it> <r23lE-25X-23@gated-at.bofh.it> <r3Rq2-4mn-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 02/19/2016 07:24 PM, Paolo Bonzini wrote:
>
>
> On 14/02/2016 12:31, Xiao Guangrong wrote:

>>   #define KVM_MAX_VCPUS 255
>>   #define KVM_SOFT_MAX_VCPUS 160
>> @@ -650,6 +651,7 @@ struct kvm_lpage_info {
>>   struct kvm_arch_memory_slot {
>>   	struct kvm_rmap_head *rmap[KVM_NR_PAGE_SIZES];
>>   	struct kvm_lpage_info *lpage_info[KVM_NR_PAGE_SIZES - 1];
>> +	unsigned short *gfn_track[KVM_PAGE_TRACK_MAX];
>
> Please add a comment at struct kvm_mmu_page_role mentioning that the
> number of role bits for shadow pages (i.e. not counting direct and
> invalid) must not exceed 15 (16 thoretically risks overflow already!),
> and counting the 14 bits that are in use.
>

Okay, good idea, it can avoid the potential issue in the future development,
will do it in the next version.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 00/11] KVM: x86: track guest page access Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-02-14 12:50 +0100
  [PATCH v3 07/11] KVM: page track: add notifier support Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-02-14 12:50 +0100
    Re: [PATCH v3 07/11] KVM: page track: add notifier support Paolo Bonzini <pbonzini@redhat.com> - 2016-02-19 13:00 +0100
      Re: [PATCH v3 07/11] KVM: page track: add notifier support Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-02-23 05:50 +0100
        Re: [PATCH v3 07/11] KVM: page track: add notifier support Paolo Bonzini <pbonzini@redhat.com> - 2016-02-23 15:20 +0100
  [PATCH v3 04/11] KVM: page track: add the framework of guest page tracking Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-02-14 12:50 +0100
    Re: [PATCH v3 04/11] KVM: page track: add the framework of guest page  tracking Paolo Bonzini <pbonzini@redhat.com> - 2016-02-19 12:30 +0100
      Re: [PATCH v3 04/11] KVM: page track: add the framework of guest page  tracking Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-02-23 05:10 +0100
  [PATCH v3 03/11] KVM: MMU: introduce kvm_mmu_slot_gfn_write_protect Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-02-14 12:50 +0100
  Re: [PATCH v3 00/11] KVM: x86: track guest page access Paolo Bonzini <pbonzini@redhat.com> - 2016-02-19 13:10 +0100
    Re: [PATCH v3 00/11] KVM: x86: track guest page access Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-02-22 11:20 +0100
      Re: [PATCH v3 00/11] KVM: x86: track guest page access Jike Song <jike.song@intel.com> - 2016-02-23 04:10 +0100
        RE: [PATCH v3 00/11] KVM: x86: track guest page access "Tian, Kevin" <kevin.tian@intel.com> - 2016-02-23 06:50 +0100
          Re: [PATCH v3 00/11] KVM: x86: track guest page access Paolo Bonzini <pbonzini@redhat.com> - 2016-02-23 13:20 +0100
        Re: [PATCH v3 00/11] KVM: x86: track guest page access Paolo Bonzini <pbonzini@redhat.com> - 2016-02-23 11:10 +0100
          Re: [PATCH v3 00/11] KVM: x86: track guest page access Jike Song <jike.song@intel.com> - 2016-02-23 13:00 +0100

csiph-web