Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1340289

Re: [PATCH v3 05/11] KVM: page track: introduce kvm_page_track_{add,remove}_page

From Xiao Guangrong <guangrong.xiao@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3 05/11] KVM: page track: introduce kvm_page_track_{add,remove}_page
Date 2016-02-23 05:30 +0100
Message-ID <r5cLN-8ok-19@gated-at.bofh.it> (permalink)
References <r23lD-25X-3@gated-at.bofh.it> <r23lD-25X-7@gated-at.bofh.it> <r3RzI-4rt-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On 02/19/2016 07:37 PM, Paolo Bonzini wrote:
>
>
> On 14/02/2016 12:31, Xiao Guangrong wrote:
>> +static bool check_mode(enum kvm_page_track_mode mode)
>> +{
>> +	if (mode < 0 || mode >= KVM_PAGE_TRACK_MAX)
>> +		return false;
>> +
>> +	return true;
>> +}
>
> Oops, forgot about this; please rename to page_track_mode_is_valid and
> make it "static inline".

Sure, it looks good to me. :)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3 05/11] KVM: page track: introduce kvm_page_track_{add,remove}_page Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-02-14 12:50 +0100
  Re: [PATCH v3 05/11] KVM: page track: introduce  kvm_page_track_{add,remove}_page Paolo Bonzini <pbonzini@redhat.com> - 2016-02-19 12:40 +0100
    Re: [PATCH v3 05/11] KVM: page track: introduce  kvm_page_track_{add,remove}_page Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-02-23 05:30 +0100
  Re: [PATCH v3 05/11] KVM: page track: introduce  kvm_page_track_{add,remove}_page Paolo Bonzini <pbonzini@redhat.com> - 2016-02-19 12:40 +0100
    Re: [PATCH v3 05/11] KVM: page track: introduce  kvm_page_track_{add,remove}_page Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-02-23 05:30 +0100
      Re: [PATCH v3 05/11] KVM: page track: introduce  kvm_page_track_{add,remove}_page Paolo Bonzini <pbonzini@redhat.com> - 2016-02-23 15:20 +0100

csiph-web