Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1342954

Re: [PATCH v3 01/11] x86/boot: enumerate documentation for the x86 hardware_subarch

From Ingo Molnar <mingo@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3 01/11] x86/boot: enumerate documentation for the x86 hardware_subarch
Date 2016-02-25 09:20 +0100
Message-ID <r5Zjs-XU-19@gated-at.bofh.it> (permalink)
References (2 earlier) <r5gZ4-2Qo-13@gated-at.bofh.it> <r5ixQ-3Z2-19@gated-at.bofh.it> <r5s4a-2dy-15@gated-at.bofh.it> <r5D9g-1Oq-15@gated-at.bofh.it> <r5KNt-7fP-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

* Andy Lutomirski <luto@amacapital.net> wrote:

> On Feb 24, 2016 12:33 AM, "Ingo Molnar" <mingo@kernel.org> wrote:
> >
> > For hard coded platform quirks I'd suggest we add x86_platform.quirks flags. For
> > example the F00F hack for Xen could be done via:
> >
> >         x86_platform.quirks.idt_remap = 0;
> >
> 
> Don't we unconditionally remap the IDT?  I think Kees did it for
> general purpose hardening due to our complete inability to hide the
> IDT address. I.e. I think we can remove the f00f condition entirely.

Yeah, indeed - I only judged by the (limited) patch context and assumed the Xen 
problem was with IDT remapping.

But what the quirk really does is only to avoid printing the f00f workaround - 
i.e. a cosmetic change. I think we should just drop the paravirt_enabled() check.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/11] x86/init: replace paravirt_enabled() were possible "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-23 08:30 +0100
  [PATCH v3 09/11] x86/boot: add BIT() to boot/bitops.h "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-23 08:30 +0100
  [PATCH v3 01/11] x86/boot: enumerate documentation for the x86 hardware_subarch "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-23 08:30 +0100
    Re: [PATCH v3 01/11] x86/boot: enumerate documentation for the x86  hardware_subarch Ingo Molnar <mingo@kernel.org> - 2016-02-23 10:00 +0100
      Re: [PATCH v3 01/11] x86/boot: enumerate documentation for the x86  hardware_subarch "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-23 11:40 +0100
        Re: [PATCH v3 01/11] x86/boot: enumerate documentation for the x86  hardware_subarch "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-23 21:50 +0100
          Re: [PATCH v3 01/11] x86/boot: enumerate documentation for the x86  hardware_subarch Ingo Molnar <mingo@kernel.org> - 2016-02-24 09:40 +0100
            Re: [PATCH v3 01/11] x86/boot: enumerate documentation for the x86 hardware_subarch Andy Lutomirski <luto@amacapital.net> - 2016-02-24 17:50 +0100
              Re: [PATCH v3 01/11] x86/boot: enumerate documentation for the x86 hardware_subarch Andy Lutomirski <luto@amacapital.net> - 2016-02-25 02:30 +0100
              Re: [PATCH v3 01/11] x86/boot: enumerate documentation for the x86  hardware_subarch Ingo Molnar <mingo@kernel.org> - 2016-02-25 09:20 +0100
            Re: [PATCH v3 01/11] x86/boot: enumerate documentation for the x86  hardware_subarch "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-03-02 01:50 +0100
              Re: [PATCH v3 01/11] x86/boot: enumerate documentation for the x86  hardware_subarch "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-03-02 20:50 +0100

csiph-web