Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1342926

[patch] drm/amd: cleanup get_mfd_cell_dev()

Show all headers | View raw

It's simpler to just use snprintf() to print this to one buffer instead
of using strcpy() and strcat().  Also using snprintf() is slightly safer
than using sprintf().

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
index 9f8cfaa..d6b0bff 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
@@ -240,12 +240,10 @@ static int acp_poweron(struct generic_pm_domain *genpd)
 static struct device *get_mfd_cell_dev(const char *device_name, int r)
 {
 	char auto_dev_name[25];
-	char buf[8];
 	struct device *dev;
 
-	sprintf(buf, ".%d.auto", r);
-	strcpy(auto_dev_name, device_name);
-	strcat(auto_dev_name, buf);
+	snprintf(auto_dev_name, sizeof(auto_dev_name),
+		 "%s.%d.auto", device_name, r);
 	dev = bus_find_device_by_name(&platform_bus_type, NULL, auto_dev_name);
 	dev_info(dev, "device %s added to pm domain\n", auto_dev_name);
 

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] drm/amd: cleanup get_mfd_cell_dev() Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-25 08:50 +0100
  Re: [patch] drm/amd: cleanup get_mfd_cell_dev() Alex Deucher <alexdeucher@gmail.com> - 2016-02-26 18:50 +0100
  Re: [patch] drm/amd: cleanup get_mfd_cell_dev() walter harms <wharms@bfs.de> - 2016-02-27 11:00 +0100
    Re: [patch] drm/amd: cleanup get_mfd_cell_dev() Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-27 11:50 +0100
      Re: [patch] drm/amd: cleanup get_mfd_cell_dev() walter harms <wharms@bfs.de> - 2016-02-27 12:20 +0100

csiph-web