Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1342618

Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7)

Show all headers | View raw

On Wed, Feb 24, 2016 at 08:29:32PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 25, 2016 at 12:13:32AM +0900, Namhyung Kim escreveu:
> > Hello,
> > 
> > This patchset implements a new feature that collects hist entries in a
> > hierachical manner.  That means lower-level entries belong to an
> > upper-level entry.  The entry hierachy is built on the sort keys
> > given, so users can set it whatever they want.  It only shows
> > top-level entries first, and user can expand/collapse it dynamically.
> > 
> >  * Changes from v6)
> >   - pass srcline, srcfile and trace_output of hist entry properly  (Jiri)
> >   - use hist_entry__snprintf_alignment()  (Jiri)
> 
> Suggestion for further improvement:
> 
> perf top --hierarchy -e sched:sched_switch -s prev_comm,prev_pid,next_comm,next_pid
> 
> Will have four levels, would be nice to have just two, perhaps expressed
> via:
> 
> perf top --hierarchy -e sched:sched_switch -s prev_comm+prev_pid,next_comm+next_pid
> 
> Where '+' would work as sort order separator, just like ',' but would
> have special meaning for --hierarchy.
> 
> What do you think?

Looks like a good addition.  To do that, a hist entry has to have its
own perf_hpp_list instead of a single perf_hpp_fmt.  I'll try to
implement it..

Thanks,
Namhyung

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHSET 00/18] perf tools: Add support for hierachy view (v7) Namhyung Kim <namhyung@kernel.org> - 2016-02-24 16:20 +0100
  [PATCH v7 16/18] perf report: Add --hierarchy option Namhyung Kim <namhyung@kernel.org> - 2016-02-24 16:20 +0100
    [tip:perf/core] perf report: Add --hierarchy option tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-25 08:50 +0100
  [PATCH v7 12/18] perf hists browser: Support collapsing/expanding whole entries in hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-02-24 16:20 +0100
    [tip:perf/core] perf hists browser: Support collapsing/expanding  whole entries in hierarchy tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-25 08:50 +0100
  [PATCH v7 11/18] perf hists browser: Count number of hierarchy entries Namhyung Kim <namhyung@kernel.org> - 2016-02-24 16:20 +0100
    [tip:perf/core] perf hists browser: Count number of hierarchy  entries tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-25 08:50 +0100
  [PATCH v7 13/18] perf hists browser: Implement hierarchy output Namhyung Kim <namhyung@kernel.org> - 2016-02-24 16:20 +0100
    [tip:perf/core] perf hists browser: Implement hierarchy output tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-25 08:50 +0100
  [PATCH v7 07/18] perf hists: Resort after filtering hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-02-24 16:30 +0100
    [tip:perf/core] perf hists: Resort after filtering hierarchy tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-25 08:50 +0100
  [PATCH v7 05/18] perf hists: Introduce hist_entry__filter() Namhyung Kim <namhyung@kernel.org> - 2016-02-24 16:30 +0100
    Re: [PATCH v7 05/18] perf hists: Introduce hist_entry__filter() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-25 00:30 +0100
      Re: [PATCH v7 05/18] perf hists: Introduce hist_entry__filter() Namhyung Kim <namhyung@kernel.org> - 2016-02-25 03:10 +0100
    [tip:perf/core] perf hists: Introduce hist_entry__filter() tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-25 08:50 +0100
  [PATCH v7 03/18] perf hists: Resort hist entries with hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-02-24 16:30 +0100
    [tip:perf/core] perf hists: Resort hist entries with hierarchy tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-25 08:50 +0100
  [PATCH v7 02/18] perf hists: Basic support of hierarchical report view Namhyung Kim <namhyung@kernel.org> - 2016-02-24 16:30 +0100
    [tip:perf/core] perf hists: Basic support of hierarchical report  view tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-02-25 08:50 +0100
  Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7) Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-24 21:10 +0100
  Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7) Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-25 00:30 +0100
    Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7) Namhyung Kim <namhyung@kernel.org> - 2016-02-25 03:20 +0100
  Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7) Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-25 02:30 +0100
    Re: [PATCHSET 00/18] perf tools: Add support for hierachy view (v7) Namhyung Kim <namhyung@kernel.org> - 2016-02-25 03:30 +0100

csiph-web