Re: [PATCH v3] net: jme: fix suspend/resume on JMC260

From	Diego Viola <diego.viola@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] net: jme: fix suspend/resume on JMC260
Date	2016-02-25 01:50 +0100
Message-ID	<r5ShX-4du-5@gated-at.bofh.it> (permalink)
References	<r5mL7-7at-9@gated-at.bofh.it> <r5oaf-7Zs-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 23, 2016 at 1:34 PM, Diego Viola <diego.viola@gmail.com> wrote:
> On Tue, Feb 23, 2016 at 12:04 PM, Diego Viola <diego.viola@gmail.com> wrote:
>> The JMC260 network card fails to suspend/resume because the call to
>> jme_start_irq() was too early, moving the call to jme_start_irq() after
>> the call to jme_reset_link() makes it work.
>>
>> Prior this change suspend/resume would fail unless /sys/power/pm_async=0
>> was explicitly specified.
>>
>> Relevant bug report: https://bugzilla.kernel.org/show_bug.cgi?id=112351
>>
>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>> ---
>>  drivers/net/ethernet/jme.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
>> index b1de7af..8adbe8f 100644
>> --- a/drivers/net/ethernet/jme.c
>> +++ b/drivers/net/ethernet/jme.c
>> @@ -3312,13 +3312,14 @@ jme_resume(struct device *dev)
>>                 jme_reset_phy_processor(jme);
>>         jme_phy_calibration(jme);
>>         jme_phy_setEA(jme);
>> -       jme_start_irq(jme);
>>         netif_device_attach(netdev);
>>
>>         atomic_inc(&jme->link_changing);
>>
>>         jme_reset_link(jme);
>>
>> +       jme_start_irq(jme);
>> +
>>         return 0;
>>  }
>>
>> --
>> 2.7.1
>>
>
> I've sent this v3 patch and I think it's better than v2 and v1, as it
> includes the link to my bug report and the description is better.
>
> Diego

Hi guys,

I just wanted to say that there's another user that have reported
success with the JMC250 (different card) using the jme driver with the
fix.

He was also getting hangs apparently.

I got an email from him, see his response here: http://ix.io/oBA

It's the same user that have posted this:
http://ubuntuforums.org/showthread.php?t=2301294

Thanks,
Diego

Thread

[PATCH v3] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-23 16:10 +0100
  Re: [PATCH v3] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-23 17:40 +0100
    Re: [PATCH v3] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-25 01:50 +0100
  Re: [PATCH v3] net: jme: fix suspend/resume on JMC260 David Miller <davem@davemloft.net> - 2016-02-25 06:00 +0100
    Re: [PATCH v3] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-02-25 16:40 +0100
    Re: [PATCH v3] net: jme: fix suspend/resume on JMC260 "Guo-Fu Tseng" <cooldavid@cooldavid.org> - 2016-03-02 06:20 +0100
      Re: [PATCH v3] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-03-03 04:20 +0100
        Re: [PATCH v3] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-03-03 07:00 +0100
          Re: [PATCH v3] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-03-03 22:20 +0100
            Re: [PATCH v3] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-03-04 05:40 +0100
          Re: [PATCH v3] net: jme: fix suspend/resume on JMC260 Diego Viola <diego.viola@gmail.com> - 2016-03-03 22:20 +0100

csiph-web