Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1342290
| From | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 01/50] pinctrl: Add devm_ apis for pinctrl_{register, unregister} |
| Date | 2016-02-24 19:30 +0100 |
| Message-ID | <r5Mmd-8s3-3@gated-at.bofh.it> (permalink) |
| References | <r5HFV-59T-43@gated-at.bofh.it> <r5HPC-5eb-39@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed 24 Feb 05:15 PST 2016, Laxman Dewangan wrote:
> Add device managed APIs devm_pinctrl_register() and
> devm_pinctrl_unregister() for the APIs pinctrl_register()
> and pinctrl_unregister().
>
> This helps in reducing code in error path and sometimes
> removal of .remove callback for driver unbind.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> drivers/pinctrl/core.c | 69 +++++++++++++++++++++++++++++++++++++++++
> include/linux/pinctrl/pinctrl.h | 6 ++++
> 2 files changed, 75 insertions(+)
>
> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
[..]
> +static int devm_pinctrl_dev_match(struct device *dev, void *res, void *data)
> +{
> + struct pctldev **r = res;
> +
> + if (!r || !*r) {
> + WARN_ON(!r || !*r);
> + return 0;
> + }
The idiomatic way is to wrap your condition in the WARN_ON; i.e.
if (WARN_ON(!r || !*r))
return 0;
> +
> + return *r == data;
> +}
> +
[..]
> +
> +/**
> + * devm_pinctrl_unregister() - Resource manager of pinctrl_unregister()
> + * @dev: device for which which resource was allocated
> + * @pctldev: the pinctrl device to unregister.
> + */
> +void devm_pinctrl_unregister(struct device *dev, struct pinctrl_dev *pctldev)
> +{
> + int ret;
> +
> + ret = devres_release(dev, devm_pinctrl_dev_release,
> + devm_pinctrl_dev_match, pctldev);
> + if (!ret)
> + WARN_ON(ret);
ret is unlikely to be non-zero in a code path only taken when ret is
zero.
Do either:
WARN_ON(devres_release(...));
rc = devres_release(..);
WARN_ON(rc);
> +}
> +EXPORT_SYMBOL_GPL(devm_pinctrl_unregister);
> +
> static int __init pinctrl_init(void)
> {
> pr_info("initialized pinctrl subsystem\n");
> diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h
> index 9ba59fc..a42e57d 100644
> --- a/include/linux/pinctrl/pinctrl.h
> +++ b/include/linux/pinctrl/pinctrl.h
> @@ -144,6 +144,12 @@ struct pinctrl_desc {
> extern struct pinctrl_dev *pinctrl_register(struct pinctrl_desc *pctldesc,
> struct device *dev, void *driver_data);
> extern void pinctrl_unregister(struct pinctrl_dev *pctldev);
> +extern struct pinctrl_dev *devm_pinctrl_register(struct device *dev,
> + struct pinctrl_desc *pctldesc,
> + void *driver_data);
> +extern void devm_pinctrl_unregister(struct device *dev,
> + struct pinctrl_dev *pctldev);
> +
> extern bool pin_is_valid(struct pinctrl_dev *pctldev, int pin);
> extern void pinctrl_add_gpio_range(struct pinctrl_dev *pctldev,
> struct pinctrl_gpio_range *range);
Apart from these style issues you have my ack.
Regards,
Bjorn
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister} Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:30 +0100
[PATCH 15/50] pinctrl: mvebu: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 15/50] pinctrl: mvebu: Use devm_pinctrl_register() for pinctrl registration Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-02-24 15:10 +0100
Re: [PATCH 15/50] pinctrl: mvebu: Use devm_pinctrl_register() for pinctrl registration kbuild test robot <lkp@intel.com> - 2016-02-24 19:40 +0100
[PATCH 10/50] pinctrl: imxl: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 37/50] pinctrl: at91: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 49/50] pinctrl: u300: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 33/50] pinctrl: adi2: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 24/50] pinctrl: samsung: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 34/50] pinctrl: amd: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 31/50] pinctrl: uniphier: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 31/50] pinctrl: uniphier: Use devm_pinctrl_register() for pinctrl registration Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-02-26 11:10 +0100
[PATCH 03/50] pinctrl: bcm281xx: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 03/50] pinctrl: bcm281xx: Use devm_pinctrl_register() for pinctrl registration Ray Jui <ray.jui@broadcom.com> - 2016-02-24 19:30 +0100
[PATCH 45/50] pinctrl: st: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 45/50] pinctrl: st: Use devm_pinctrl_register() for pinctrl registration Maxime Coquelin <maxime.coquelin@st.com> - 2016-02-24 17:20 +0100
[PATCH 47/50] pinctrl: tz1090-pdc: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 01/50] pinctrl: Add devm_ apis for pinctrl_{register, unregister} Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 01/50] pinctrl: Add devm_ apis for pinctrl_{register, unregister} Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-02-24 19:30 +0100
Re: [PATCH 01/50] pinctrl: Add devm_ apis for pinctrl_{register, unregister} Philipp Zabel <p.zabel@pengutronix.de> - 2016-02-25 15:50 +0100
[PATCH 30/50] pinctrl: tegra-xusb: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 30/50] pinctrl: tegra-xusb: Use devm_pinctrl_register() for pinctrl registration Stephen Warren <swarren@wwwdotorg.org> - 2016-02-24 17:50 +0100
[PATCH 29/50] pinctrl: tegra: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 29/50] pinctrl: tegra: Use devm_pinctrl_register() for pinctrl registration Stephen Warren <swarren@wwwdotorg.org> - 2016-02-24 17:50 +0100
[PATCH 32/50] pinctrl: vt8500: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 43/50] pinctrl: pistachio: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 35/50] pinctrl: as3722: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 05/50] pinctrl: cygnus-mux: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 05/50] pinctrl: cygnus-mux: Use devm_pinctrl_register() for pinctrl registration Ray Jui <ray.jui@broadcom.com> - 2016-02-24 19:30 +0100
[PATCH 42/50] pinctrl: pic32: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 42/50] pinctrl: pic32: Use devm_pinctrl_register() for pinctrl registration Joshua Henderson <joshua.henderson@microchip.com> - 2016-02-25 21:40 +0100
[PATCH 46/50] pinctrl: tb10x: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 19/50] pinctrl: ssbi-gpi: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 19/50] pinctrl: ssbi-gpi: Use devm_pinctrl_register() for pinctrl registration Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-02-24 19:10 +0100
[PATCH 07/50] pinctrl: nsp-gpio: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 44/50] pinctrl: rockchip: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 44/50] pinctrl: rockchip: Use devm_pinctrl_register() for pinctrl registration Heiko Stübner <heiko@sntech.de> - 2016-03-02 22:50 +0100
[PATCH 17/50] pinctrl: spmi-gpio: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 17/50] pinctrl: spmi-gpio: Use devm_pinctrl_register() for pinctrl registration Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-02-24 19:10 +0100
[PATCH 18/50] pinctrl: spmi: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 18/50] pinctrl: spmi: Use devm_pinctrl_register() for pinctrl registration Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-02-24 19:10 +0100
[PATCH 12/50] pinctrl: intel: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 12/50] pinctrl: intel: Use devm_pinctrl_register() for pinctrl registration Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-25 12:50 +0100
[PATCH 36/50] pinctrl: at91-pio4: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 38/50] pinctrl: digicolor: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 38/50] pinctrl: digicolor: Use devm_pinctrl_register() for pinctrl registration Baruch Siach <baruch@tkos.co.il> - 2016-02-24 14:50 +0100
[PATCH 50/50] pinctrl: zynq: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 50/50] pinctrl: zynq: Use devm_pinctrl_register() for pinctrl registration Sören Brinkmann <soren.brinkmann@xilinx.com> - 2016-02-26 04:50 +0100
[PATCH 48/50] pinctrl: tz1090 Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 41/50] pinctrl: palmas: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 28/50] pinctrl: ssbi-mpp: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 28/50] pinctrl: ssbi-mpp: Use devm_pinctrl_register() for pinctrl registration Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-02-24 19:10 +0100
[PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register() for pinctrl registration Matthias Brugger <matthias.bgg@gmail.com> - 2016-02-24 14:40 +0100
Re: [PATCH 13/50] pinctrl: mtk-common: Use devm_pinctrl_register() for pinctrl registration Hongzhou Yang <hongzhou.yang@mediatek.com> - 2016-02-24 21:40 +0100
[PATCH 40/50] pinctrl: lpc18xx: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 40/50] pinctrl: lpc18xx: Use devm_pinctrl_register() for pinctrl registration Joachim Eastwood <manabian@gmail.com> - 2016-02-24 16:10 +0100
[PATCH 21/50] pinctrl: msm: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 14/50] pinctrl: meson: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 14/50] pinctrl: meson: Use devm_pinctrl_register() for pinctrl registration Carlo Caione <carlo@caione.org> - 2016-02-26 22:00 +0100
[PATCH 22/50] pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 22/50] pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-26 23:30 +0100
[PATCH 16/50] pinctrl: nomadic: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 09/50] pinctrl: imx: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 09/50] pinctrl: imx: Use devm_pinctrl_register() for pinctrl registration Philipp Zabel <p.zabel@pengutronix.de> - 2016-02-25 15:50 +0100
Re: [PATCH 09/50] pinctrl: imx: Use devm_pinctrl_register() for pinctrl registration Shawn Guo <shawnguo@kernel.org> - 2016-02-29 04:10 +0100
[PATCH 06/50] pinctrl: iproc-gpio: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
[PATCH 39/50] pinctrl: lantiq: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:40 +0100
Re: [PATCH 39/50] pinctrl: lantiq: Use devm_pinctrl_register() for pinctrl registration John Crispin <blogic@openwrt.org> - 2016-02-25 15:30 +0100
[PATCH 11/50] pinctrl: cherryview: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
Re: [PATCH 11/50] pinctrl: cherryview: Use devm_pinctrl_register() for pinctrl registration Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-02-25 12:50 +0100
[PATCH 26/50] pinctrl: spear: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
Re: [PATCH 26/50] pinctrl: spear: Use devm_pinctrl_register() for pinctrl registration Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-25 03:20 +0100
[PATCH 23/50] pinctrl: exynos5440: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
[PATCH 27/50] pinctrl: stm32: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
Re: [PATCH 27/50] pinctrl: stm32: Use devm_pinctrl_register() for pinctrl registration Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-02-25 15:10 +0100
[PATCH 08/50] pinctrl: berlin: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
Re: [PATCH 08/50] pinctrl: berlin: Use devm_pinctrl_register() for pinctrl registration Antoine Ténart <antoine.tenart@free-electrons.com> - 2016-02-24 18:40 +0100
[PATCH 04/50] pinctrl: bcm2835: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
Re: [PATCH 04/50] pinctrl: bcm2835: Use devm_pinctrl_register() for pinctrl registration Ray Jui <ray.jui@broadcom.com> - 2016-02-24 19:30 +0100
[PATCH 25/50] pinctrl: ish-pfc: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
Re: [PATCH 25/50] pinctrl: ish-pfc: Use devm_pinctrl_register() for pinctrl registration Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-24 15:00 +0100
[PATCH 20/50] pinctrl: ssbi-mpp: Use devm_pinctrl_register() for pinctrl registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 14:50 +0100
[PATCH 02/50] pinctrl: Add resource management devm_pinctrl_{register, unregister} Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 15:00 +0100
Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister} Stefan Wahren <stefan.wahren@i2se.com> - 2016-02-24 18:30 +0100
Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister} Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-24 18:30 +0100
Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister} Linus Walleij <linus.walleij@linaro.org> - 2016-02-25 15:20 +0100
Re: [PATCH 00/50] pinctrl: Add and use devm_ apis for pinctrl_{register, unregister} Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-28 16:00 +0100
csiph-web