Re: [PATCH] thp: call pmdp_invalidate() with correct virtual address

From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] thp: call pmdp_invalidate() with correct virtual address
Date	2016-02-24 19:50 +0100
Message-ID	<r5MFA-9c-7@gated-at.bofh.it> (permalink)
References	<r5K13-6Gg-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 24, 2016 at 7:58 AM, Kirill A. Shutemov
<kirill.shutemov@linux.intel.com> wrote:
> Sebastian Ott and Gerald Schaefer reported random crashes on s390.
> It was bisected to my THP refcounting patchset.
>
> The problem is that pmdp_invalidated() called with wrong virtual
> address. It got offset up by HPAGE_PMD_SIZE by loop over ptes.
>
> The solution is to introduce new variable to be used in loop and don't
> touch 'haddr'.

Thanks, I applied this directly rather than wait for this to go
through Andrew (which would have been "proper channels").

This issue has been worrying me for a while now and was my main core
worry for 4.5. Good to have it resolved, and thanks to everybody who
tested and got involved.

                 Linus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] thp: call pmdp_invalidate() with correct virtual address "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-24 17:00 +0100
  Re: [PATCH] thp: call pmdp_invalidate() with correct virtual address Will Deacon <will.deacon@arm.com> - 2016-02-24 17:20 +0100
  Re: [PATCH] thp: call pmdp_invalidate() with correct virtual address Linus Torvalds <torvalds@linux-foundation.org> - 2016-02-24 19:50 +0100

csiph-web